Remove exec from Watches, add Status(Un)Healthy things Watch publishes #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
onChange
field from watches per the design in RFD86. (Well, ok, it removes the field frombackends
because I haven't made that last config change yet). A user who wants the effect of the CPv2onChange
handler will create a job with a configuration like:There are several examples of this in both the unit tests and the integration tests.
Note that this PR currently includes commits from #312 and as usual I'll rebase this once that's been merged for easier review. 3df4e2f is the only commit that will be in this PR when that's done.
I'm also feeling like I missed something even though all the tests pass (locally at least), so I want to take one more pass through anyways.Good-to-go.cc @cheapRoc @geek @jasonpincin @misterbisson