Split-out health check config #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2017
|
This feature has undergone some internal review and we've decided to cut it, as the semantics of multiple health checks for a service don't really make sense given that we can only report to Consul once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out the
healthconfig from thejobsconfig, per the design in RFD86. One thing that diverges from the RFD is that we were missing theheartbeatfield for jobs. We could call thispollto be consistent with the checks, but I'd rather call itheartbeatbecause a) that's what we're calling it internally, and b) it has a different behavior than the polling.This PR depends on and includes the work in #312, #314, and #315 so I'll rebase this when those are merged. The only commit in this PR will be 2791b36
cc @misterbisson @cheapRoc @jasonpincin @geek