Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix typo #13

wants to merge 1 commit into from

Conversation

peecky
Copy link

@peecky peecky commented Aug 24, 2014

I found a meaningless if condition which always become false, because not operator(!) is evaluated before the instanceof operator.

@StefH
Copy link

StefH commented Sep 10, 2016

This is actually a compile error, not a type.

Also fixed in #21

@Voles
Copy link

Voles commented Dec 8, 2016

@peecky were you able to resolve this based on @StefH's comment?

@StefH
Copy link

StefH commented Jan 5, 2017

@peecky : Any update?

@stephenwvickers
Copy link

I have seen there is little progress on this project over the past few years. My project, the net-snmp project, depends on this project, so I have cloned it and migrated (i.e. copied) all the outstanding issues and pull requests.

I will be releasing a new version of my version of this project under the asn1-ber namespace on npmjs.org by the end of the week which should address this particular item (I've already pushed the current code to this namespace to reserve it).

I am now tracking all changes under my own copy at asn1-ber. Note that this is not a "fork" but a clone and fresh commit to a new repository. I have of course retained all copyrights and attributed back the original author.

There are quite a few projects dependant on this project, and I want to make sure there is momentum on the issues and feature requests reported.

@stephenwvickers
Copy link

This issue has been addressed in my version of this project which has now been published to npm:

https://www.npmjs.com/package/asn1-ber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants