Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean logic error using instanceof in the writeStringArray() method in lib/ber/writer.js #9

Closed
stephenwvickers opened this issue Jul 19, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@stephenwvickers
Copy link
Collaborator

See: TritonDataCenter/node-asn1#13

@@ -160,7 +160,7 @@ Writer.prototype.writeBuffer = function(buf, tag) {
  
  
  Writer.prototype.writeStringArray = function(strings) {
 -  if ((!strings instanceof Array))
 +  if (!(strings instanceof Array))
      throw new TypeError('argument must be an Array[String]');
  
    var self = this;
@stephenwvickers
Copy link
Collaborator Author

stephenwvickers commented Jul 19, 2017

Original requester: @peecky

@stephenwvickers stephenwvickers changed the title fix typo Boolean logic error using instanceof in the writeStringArray() method in lib/ber/writer.js Jul 19, 2017
@stephenwvickers stephenwvickers self-assigned this Jul 19, 2017
@stephenwvickers stephenwvickers added this to the 1.0.0 milestone Jul 19, 2017
stephenwvickers added a commit that referenced this issue Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant