Update to use TS1.5 services #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there are quite a lot of changes in the JS files because the release versions haven’t been getting compiled using |
|
👍 Merge whenever you feel like we should release this. I leave that decision completely up to you ❤️ |
|
I think it needs to wait till at least more of the ES6 module support is in place, since right now the support in master is bit of a mixed bag (imports with destructuring are supported but it crashes if you generate declarations and doesn’t support the export default syntax). I’ll keep updating this PR until everything seems stable. |
|
@csnover I'm going to join you on this branch. I'll start by bringing in master right now. |
|
closed in favor of : #179 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to use one of the prerelease 1.5 compilers from Arnavion’s nightlies along with a few changes to services that are necessary for working with 1.5. Maybe this can just go on a separate branch until 1.5 is fully baked, but it seems like it’s far enough along now that we should start working with it.
I also note that 1.5 appears to be delivered along with a server for language services (tsserver) which could be more useful in the long term than having our own child language services process, but this PR just gets things fixed up to work again with 1.5.