-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dockerfile #12
Conversation
…ifier into create-dockerfile
Todo: Add |
Also add brief instructions for running docker container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting up the environment, Ben. Just spotted 2 small issues:
deepchecks
version confirmation inenvironment.yml
- Automate the installation for
deepchecks
inDockerfile
Please see comments on environment.yml
and Dockerfile
for detail.
RUN mamba update --quiet --file /tmp/conda-linux-64.lock \ | ||
&& mamba clean --all -y -f \ | ||
&& fix-permissions "${CONDA_DIR}" \ | ||
&& fix-permissions "/home/${NB_USER}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to automate the installation for deepchecks
during the build process by adding RUN pip install deepchecks==0.3.2
at the end of the Dockerfile
(for deepchecks
version, please refer to the comment on the environment.yml
file to confirm which version to install).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the deepchecks
package not included on your end when you run the container? It seems to properly install on my end. Let me know, and if you have issues I will make sure to implement this.
Update: refer to my following comment about the environment.yml
file regarding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container runs fine on my end with deepchecks
installed, thanks @bfrizzell01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the requested line to Dockerfile
. Data Validation should now work properrly, @y1chi-z .
- python=3.11 | ||
- pandera=0.21.0 | ||
- deepchecks=0.3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking for the pinned version of deepchecks
, any particular reason of using 0.3.2
? 0.18.1
should be the latest release, if there are any compatibility issue with this version, please disregard this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3.2
was the version that conda automatically installed into our environment with the other packages, so i'm assuming that is the version that is most compatible. But I can try it with the newer version and see if there are any issues.
Update: It does seem that version 0.18.1
has conflicts with other pinned package versions, so I've added a line to Dockerfile
to include the newest version.
environment.yml
conda-lock.yml
, replaced withconda-linux-64.lock
Dockerfile