-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dockerfile #12
Merged
Merged
Changes from 14 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e38a37d
initialize Dockerfile and explicit conda-lock
bfrizzell01 6b9b2e8
fixed Dockerfile, added python dependency
bfrizzell01 1804542
added docker publish action
bfrizzell01 990cb37
Update docker-publish.yml for create-dockerfile branch
bfrizzell01 4ffee67
Update docker-publish.yml
bfrizzell01 630c2c4
edited Dockerfile
bfrizzell01 94530e2
Merge branch 'create-dockerfile' of github.com:UBC-MDS/mushroom_class…
bfrizzell01 3000680
added pandera to env
bfrizzell01 807ac0f
created docker compose file
bfrizzell01 0898f77
Update docker-compose.yml
bfrizzell01 39819cd
added deepcheck pckg to environment
bfrizzell01 d6a499a
added deepchecks to environment
bfrizzell01 e188bd4
Update tag
bfrizzell01 83f6122
how to access jupyterlab in container image
bfrizzell01 56812f1
Update Dockerfile to include deepchecks v0.18.1
bfrizzell01 fe441d2
Update Dockerfille typo
bfrizzell01 035bf44
Update another Dockerfile typo
bfrizzell01 7046d81
Add pip install deepchecks to Dockerfile
bfrizzell01 a5070bf
fix typo
bfrizzell01 0d580f8
updated tag
bfrizzell01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Publishes docker image, pinning actions to a commit SHA, | ||
# and updating most recently built image with the latest tag. | ||
# Can be triggered by either pushing a commit that changes the `Dockerfile`, | ||
# or manually dispatching the workflow. | ||
|
||
name: Publish Docker image | ||
|
||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- main | ||
- create-dockerfile | ||
paths: | ||
- 'Dockerfile' | ||
- 'conda-linux-64.lock' | ||
|
||
jobs: | ||
push_to_registry: | ||
name: Push Docker image to Docker Hub | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out the repo | ||
uses: actions/checkout@v4 | ||
|
||
- name: Log in to Docker Hub | ||
uses: docker/login-action@v3 | ||
with: | ||
username: ${{ secrets.DOCKER_USERNAME }} | ||
password: ${{ secrets.DOCKER_PASSWORD }} | ||
|
||
- name: Extract metadata (tags, labels) for Docker | ||
id: meta | ||
uses: docker/metadata-action@v5 | ||
with: | ||
images: bfrizzell/mushroom_classifier | ||
tags: | | ||
type=raw, value={{sha}},enable=${{github.ref_type != 'tag' }} | ||
type=raw, value=latest | ||
|
||
- name: Build and push Docker image | ||
uses: docker/build-push-action@v6 | ||
with: | ||
context: . | ||
file: ./Dockerfile | ||
push: true | ||
tags: ${{ steps.meta.outputs.tags }} | ||
labels: ${{ steps.meta.outputs.labels }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,7 @@ | |
*.log | ||
|
||
# ignore caches | ||
.jupyter/ | ||
.jupyter/ | ||
.cache/ | ||
.ipython/ | ||
.local/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
FROM quay.io/jupyter/minimal-notebook:afe30f0c9ad8 | ||
|
||
COPY conda-linux-64.lock /tmp/conda-linux-64.lock | ||
RUN mamba update --quiet --file /tmp/conda-linux-64.lock \ | ||
&& mamba clean --all -y -f \ | ||
&& fix-permissions "${CONDA_DIR}" \ | ||
&& fix-permissions "/home/${NB_USER}" | ||
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to automate the installation for
deepchecks
during the build process by addingRUN pip install deepchecks==0.3.2
at the end of theDockerfile
(fordeepchecks
version, please refer to the comment on theenvironment.yml
file to confirm which version to install).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
deepchecks
package not included on your end when you run the container? It seems to properly install on my end. Let me know, and if you have issues I will make sure to implement this.Update: refer to my following comment about the
environment.yml
file regarding this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container runs fine on my end with
deepchecks
installed, thanks @bfrizzell01There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the requested line to
Dockerfile
. Data Validation should now work properrly, @y1chi-z .