feat: tenderly simulation button in transaction builder #120
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if (!safe) { | ||
| throw new Error('No safe data'); | ||
| } |
There was a problem hiding this comment.
this shouldn't be null at this point in the flow but we need to make ts happy
tailwind.config.js
Outdated
| green: '#21b66f', | ||
| red: '#ff3856' | ||
| green: 'hsl(var(--green) / <alpha-value>)', | ||
| red: 'hsl(var(--red) / <alpha-value>)' |
There was a problem hiding this comment.
this is backward compatible. any existing references to green or red will just default to an alpha value of 1
gsteenkamp89
force-pushed
the
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
branch
from
177944b to
b29827f
Compare
|
|
||
| interface ResultUrl { | ||
| url: string; // This is the URL to the simulation result page (public or private). | ||
| public: boolean; // This is false if the project is not publicly accessible. |
There was a problem hiding this comment.
for frontend, we might also validate that this is true, otherwise the returned url will not be accessible. Normally API is expected to run with public project, but its better to check it
There was a problem hiding this comment.
Ah great thanks Reinis! I think, correct me if I'm wring, but we've configured the API to always be using UMA's project since we're always interacting with the OG. Will this ever change? I suppose it might in which case we'd probably have to show some sort of warning that the link might not be accessible to the user.
There was a problem hiding this comment.
yes, API uses public Tenderly project credentials, but still worth checking as this can be changed in project settings
|
im not sure how to do this, but we may need to pr this to the snapshot repo rather than uma/master |
daywiss
force-pushed
the
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
branch
from
df8d764 to
e7a0adf
Compare
|
getting some strange behavior with the proxy vs implementation logic.
|
daywiss
force-pushed
the
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
branch
from
25ad941 to
3eeea1e
Compare
gsteenkamp89
force-pushed
the
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
branch
from
748b8cb to
021a789
Compare
|
accepted upstream |
Motivation
We want to simulate transaction before the proposal gets posted on chain.
screenshots