Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core mainnet #126

Closed
wants to merge 5 commits into from
Closed

feat: add core mainnet #126

wants to merge 5 commits into from

Conversation

Reinis-FRP
Copy link

@Reinis-FRP Reinis-FRP commented Feb 13, 2024

Fixes https://linear.app/uma/issue/UMA-2392/add-core-to-osnapsafesnap-plugins-in-snapshot

Changes in this PR: adds Core mainnet to both oSnap and safeSnap plugins

There are still couple of outstanding issues for adding Core support:

  • Safe app links in both oSnap/safeSnap tx builder does not work as Core Safe app instance does not support safe externally
  • Transaction builder is not able to automatically fetch contract ABI since Core chain explorer requires API key to fetch that.
  • Transaction builder fails to load token/NFT balances for Core as Covalent service does not support Core network: https://www.covalenthq.com/docs/networks/

How to test and review this PR?

Fixes: https://linear.app/uma/issue/UMA-2410/point-cordao-treasury-links-to-coredao-safe-app

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:48pm
snapshot-goerli ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:48pm

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

linear bot commented Feb 13, 2024

@Reinis-FRP Reinis-FRP marked this pull request as ready for review February 13, 2024 21:01
Copy link

@daywiss daywiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. dont merge, i will need to pr this to snapshot eventually. i dont think theres a huge rush unless this is blocking your dev

@daywiss daywiss self-requested a review February 20, 2024 19:48
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

linear bot commented Feb 20, 2024

@daywiss
Copy link

daywiss commented Feb 22, 2024

prd here snapshot-labs/snapshot-v1#4575

@daywiss daywiss closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants