feat: add core network support to osnap plugin #4575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to add core dao support in oSnap. This adds core support in oSnap plugin and safesnap plugin. Due to external dependencies we are only able to get partial support for core but basic transactions will work. We are shipping this with partial support for Core, as the Coredao team is aware of this.
There are still couple of outstanding issues for adding Core support:
How to test
TODO: Once third party dependencies are worked out, update to enable missing features