Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core network support to osnap plugin #4575

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

daywiss
Copy link
Contributor

@daywiss daywiss commented Feb 22, 2024

Summary

We want to add core dao support in oSnap. This adds core support in oSnap plugin and safesnap plugin. Due to external dependencies we are only able to get partial support for core but basic transactions will work. We are shipping this with partial support for Core, as the Coredao team is aware of this.

There are still couple of outstanding issues for adding Core support:

  • Safe app links in both oSnap/safeSnap tx builder does not work as Core Safe app instance does not support safe externally
  • Transaction builder is not able to automatically fetch contract ABI since Core chain explorer requires API key to fetch that.
  • Transaction builder fails to load token/NFT balances for Core as Covalent service does not support Core network:

How to test

  1. Add core treasury to safe snap enabled space
  2. See that you can create proposals with osnap and core chain transactions

TODO: Once third party dependencies are worked out, update to enable missing features

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link
Contributor

@samuveth samuveth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@samuveth samuveth merged commit f654380 into master Feb 23, 2024
5 checks passed
@samuveth samuveth deleted the reinis-frp/core-network branch February 23, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants