Noproj application bug - Missing keywords prevent use of Bullet collision detection engine.

[kledmundson]

ISIS version(s) affected: latest

Description

In OSIRIS-REx processing a bug was discovered in the noproj application. Missing keywords (RayTraceEngine, BulletParts, Tolerance) related to the shapemodel are dropped when noproj creates the output label. This causes problems for Bullet engine configurations that use the .conf or .obj formats. In fact, Bullet was never used. The NAIF DSK toolkit was used by default for geometry calculations. This has been resolved in the UofA OSIRIS-REx ISIS code base.

How to reproduce

Relevant Code…

Original code fragment

// Clean up the kernels group... delete everything that isn't internalized or the orig frame
// code
PvlGroup &kernelsGroup = ocube->group("Kernels");
for (int keyIndex = kernelsGroup.keywords() - 1; keyIndex >= 0; keyIndex--) {
PvlKeyword &kernelsKeyword = kernelsGroup[keyIndex];

    bool isTable = false;
    bool isFrameCode = kernelsKeyword.isNamed("NaifFrameCode") ||
                       kernelsKeyword.isNamed("NaifIkCode");
    bool isShapeModel = kernelsKeyword.isNamed("ShapeModel”);

Fixed code fragment

// Clean up the kernels group... delete everything that isn't internalized or the orig frame
// code
PvlGroup &kernelsGroup = ocube->group("Kernels");
for (int keyIndex = kernelsGroup.keywords() - 1; keyIndex >= 0; keyIndex--) {
PvlKeyword &kernelsKeyword = kernelsGroup[keyIndex];

    bool isTable = false;
    bool isFrameCode = kernelsKeyword.isNamed("NaifFrameCode") ||
                       kernelsKeyword.isNamed("NaifIkCode");
    bool isShapeModel = kernelsKeyword.isNamed("ShapeModel") ||
                        kernelsKeyword.isNamed("RayTraceEngine") ||
                        kernelsKeyword.isNamed("BulletParts") ||
                        kernelsKeyword.isNamed("Tolerance");

Possible Solution

Additional context