gllssi2isis Original Label Fix #3226

acpaquette · 2019-04-15T18:24:31Z

Fixes the gllssi2isis to output the original label if the ingestion app is using its "summing" mode.

Description

Updated setOutputCube in ProcessImport to expose more parameters when accessing Process's setOutputCube function. Specifically, the new "base" setOutputCube methods allows for custom attribute object, number of samples, lines, and bands. The old method just default to this new methods with the appropriate parameters passed in.

Related Issue

Fixes #3207.

Motivation and Context

The old label is required in some ISIS applications. Attaching the original labels to these ingested cubes will allow those cubes to be used in the ISIS applications that require the original label.

How Has This Been Tested?

Tested using a test that already exists in the system. Test will need to be updated as the pvl output of the cube label will change since it now has the original label.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

… dev

…ng cube.

… dev

isis/src/galileo/apps/gllssi2isis/main.cpp

scsides · 2019-04-15T19:06:35Z

isis/src/base/objs/ProcessImport/ProcessImport.cpp

-    CubeAttributeOutput &att =
-      Application::GetUserInterface().GetOutputAttribute(parameter);
-
+  Isis::Cube *ProcessImport::SetOutputCube(const QString &parameter, CubeAttributeOutput &att, const int ns, const int nl, const int nb) {


Since this call is being passed the user interface parameter name, I don't see the reason to pass in the CubeAttribute. It is part of what the user typed. Also, the original SetOutputCube member parsed the value of the parameter and pulled the attributes off in order to call the parents member. Seems reasonable to continue doing this and not make the application programmer do this.

No longer necessary as the change to ProcessImport was unnecessary

isis/src/base/objs/ProcessImport/ProcessImport.cpp

scsides · 2019-04-15T19:36:59Z

isis/src/base/objs/ProcessImport/ProcessImport.h

   *                            values.
-   *
+   *   @history 2019-04-15 Adam Paquette - Exposed the ns, nl, nb (number of samples, lines, and bands)
+   *                           for the setOutputCube function. Updated existing setOutputCube methods


Exposed by adding a new SetOutputCube member

No longer necessary as the change to ProcessImport was unnecessary

scsides

See individual comments

jlaura · 2019-04-15T22:20:38Z

isis/src/base/objs/ProcessImport/ProcessImport.h

@@ -163,11 +163,9 @@ namespace Isis {
   *                           was made to accomodate Rosetta VIRTIS-m calibrated data files and
   *                           has no impact on other supported BIP files.
   *                           Fixes #5398.
-   *   @history 2018-07-19 Tyler Wilson - Added support for 4-byte UnsignedInteger special pixel
+   *   @history 208-07-19 Tyler Wilson - Added support for 4-byte UnsignedInteger special pixel


Was removed due to me clobbering the changes I had made to the ProcessImport files. WIll re-add

SgStapleton · 2019-04-15T23:00:31Z

isis/src/galileo/apps/gllssi2isis/main.cpp

-    summedOutput->create(ui.GetFileName("TO"));
-    p.StartProcess(translateData);
+    p.SetDimensions(p.Samples() / 2, p.Lines() / 2, p.Bands());
+    summedOutput = p.SetOutputCube("TO");


ocube = p.SetOutputCube("TO"); ?

Do we need summedOutput now...?

I just noticed that summedOutput is being used further down. Is that why we still need to instantiate it here?

SgStapleton · 2019-04-15T23:05:40Z

isis/src/galileo/apps/gllssi2isis/main.cpp

@@ -182,7 +174,7 @@ void fixPvl(QString fileName){



-void translateData(Buffer &inData) {
+void translateData(Isis::Buffer &inData) {
  summedOutput->write(inData);


Could this be replaced with ocube to get rid of summedOutput altogether?

acpaquette · 2019-04-16T01:24:30Z

Apologies with the drastic changes that are happening between commits 😬

scsides · 2019-04-16T13:16:26Z

isis/src/galileo/apps/gllssi2isis/main.cpp

-  FileName out = ui.GetFileName("TO");
-
-
+  FileName outFile = ui.GetFileName("TO");


Is this used anywhere?

Will make a change to use it

…ime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification

…ime (DOI-USGS#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification

* Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification

…ime (DOI-USGS#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification

* Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model

* Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint (#3146) * Fix time-formatting in reingested CaSSIS images. (#3149) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added LineEqationTests.cpp (#3152) * History entry added to cube after running sumspice. Fixes #4972. (#658) * Added WriteHistory() method to SumFinder. * Renamed method. * Refactored writeHistory to be up to isis standards. * Added history entries and updated code to be up to isis standards. * Updated history entry. * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * Various minor mods to the readme (#3165) * Added FileList test (#3168) * Added LineEqationTests.cpp * Added FileListTests.cpp Implemented an istream constructor in FileList.cpp to help with testing. * added FileList tests. implemented istream constructor for FileList.cpp to help with testing. * fixed whitespace issues in FileListTests.cpp * Update FileListTests.cpp * Cleaned up data area wording in install guide (#3170) * temp commits for testing bundle with lidar * temp commits to bundle lidar * Add ISIS3 update instructions to README (#3175) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * Updating Contributing.md (#3179) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * updated contributing guidelines * removed mentions of TC * Added LatitudeTest using Gtest (#3160) * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. * Created LatitudeTests. * Added C-Shell variable setup (#3173) * Added C-Shell variable setup * Fixed history * Made a bit more pythonic * Updates BulletDSKShape's methods for multisegment DSKs (#3181) * fixed DSK segment methods * fixed some errors * added contraints * fixed bug where an extra segment was added * Fixed memory leak in Bullet shape model (#3180) * Added AffineTests (#3166) * Add Longitude gtest (rebase of #601) (#3182) * Created gtest for Longitude class * Remove old Longitude test * Fix syntax for Longitude Tests * Remove comment * Revert "Remove old Longitude test" This reverts commit 608d3fd. * Cleaned file, organzied test cases * Fixed failing copy constructor test * Fixed bug where findrx was not adding a history blob to the input cube (#3186) * Added writeHistory to findrx. * Rearranged includes in findrx. * Removed extra exceptions writing controlnets (#3185) * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed, References #2591). (#3193) * updates to ControlPoint::ComputeApriori * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed (References #2591). Added check to IsConstrained() method to see if point type is Free, in which case we ignore stored a priori sigmas on the coordinates. * added isis error when GenericTransform::calculateInverse gets empty matrix (#3195) * Writing 0 Value Residuals to PVL (#3194) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixing errors introduced with the changes to ProcessExportPds4.cpp for the tgo sprint. (#3202) * Github/Discuss Documentation Update (#3203) * Updated website documentation to point to github and discuss where appropriate * Updated last install link * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and tru… (#3200) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Update README.md (#3204) Updated to include instructions for release candidate builds on anaconda * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * updates for bundle lidar * updates for bundle lidar * added history comment noting that piecewise polynomial functionality has been disabled to get the lidar stuff working * updates for bundle with lidar

* Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint (#3146) * Fix time-formatting in reingested CaSSIS images. (#3149) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added LineEqationTests.cpp (#3152) * History entry added to cube after running sumspice. Fixes #4972. (#658) * Added WriteHistory() method to SumFinder. * Renamed method. * Refactored writeHistory to be up to isis standards. * Added history entries and updated code to be up to isis standards. * Updated history entry. * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * Various minor mods to the readme (#3165) * Added FileList test (#3168) * Added LineEqationTests.cpp * Added FileListTests.cpp Implemented an istream constructor in FileList.cpp to help with testing. * added FileList tests. implemented istream constructor for FileList.cpp to help with testing. * fixed whitespace issues in FileListTests.cpp * Update FileListTests.cpp * Cleaned up data area wording in install guide (#3170) * temp commits for testing bundle with lidar * temp commits to bundle lidar * Add ISIS3 update instructions to README (#3175) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * Updating Contributing.md (#3179) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * updated contributing guidelines * removed mentions of TC * Added LatitudeTest using Gtest (#3160) * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. * Created LatitudeTests. * Added C-Shell variable setup (#3173) * Added C-Shell variable setup * Fixed history * Made a bit more pythonic * Updates BulletDSKShape's methods for multisegment DSKs (#3181) * fixed DSK segment methods * fixed some errors * added contraints * fixed bug where an extra segment was added * Fixed memory leak in Bullet shape model (#3180) * Added AffineTests (#3166) * Add Longitude gtest (rebase of #601) (#3182) * Created gtest for Longitude class * Remove old Longitude test * Fix syntax for Longitude Tests * Remove comment * Revert "Remove old Longitude test" This reverts commit 608d3fd. * Cleaned file, organzied test cases * Fixed failing copy constructor test * Fixed bug where findrx was not adding a history blob to the input cube (#3186) * Added writeHistory to findrx. * Rearranged includes in findrx. * Removed extra exceptions writing controlnets (#3185) * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed, References #2591). (#3193) * updates to ControlPoint::ComputeApriori * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed (References #2591). Added check to IsConstrained() method to see if point type is Free, in which case we ignore stored a priori sigmas on the coordinates. * added isis error when GenericTransform::calculateInverse gets empty matrix (#3195) * Writing 0 Value Residuals to PVL (#3194) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixing errors introduced with the changes to ProcessExportPds4.cpp for the tgo sprint. (#3202) * Github/Discuss Documentation Update (#3203) * Updated website documentation to point to github and discuss where appropriate * Updated last install link * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and tru… (#3200) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Update README.md (#3204) Updated to include instructions for release candidate builds on anaconda * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * updates for bundle lidar * updates for bundle lidar * added history comment noting that piecewise polynomial functionality has been disabled to get the lidar stuff working * updates for bundle with lidar * removed commented code

* Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Updates to Kaguya TC big PR based on comments

* Added GaussianDistribution Test. * Removed unused method and added test for exception. * Changed comment. * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release (#3254) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release * Fixing date on version file * Put the Probability method back and removed the old unit test and truth data.

* Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Update unit test for Kaguya TC to match output of updated camera model (#3241) * Merge dev info kaguyatc (#3243) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update kaguyatc branch from dev (#3245) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Moddified description (#3246) * updates for review comments (#3277) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Updates to Kaguya TC big PR based on comments * Update kaguyatc2isis.xml Replace tab with spaces. * Fix spacing * Updated comment for clarity * Move comment

* Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (DOI-USGS#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (DOI-USGS#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (DOI-USGS#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (DOI-USGS#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (DOI-USGS#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Update unit test for Kaguya TC to match output of updated camera model (DOI-USGS#3241) * Merge dev info kaguyatc (DOI-USGS#3243) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification * Update kaguyatc branch from dev (DOI-USGS#3245) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (DOI-USGS#3244) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (DOI-USGS#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (DOI-USGS#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (DOI-USGS#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (DOI-USGS#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (DOI-USGS#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Moddified description (DOI-USGS#3246) * updates for review comments (DOI-USGS#3277) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (DOI-USGS#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (DOI-USGS#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (DOI-USGS#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (DOI-USGS#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (DOI-USGS#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (DOI-USGS#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (DOI-USGS#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (DOI-USGS#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (DOI-USGS#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (DOI-USGS#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (DOI-USGS#3230) * Update README.md (DOI-USGS#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (DOI-USGS#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue DOI-USGS#3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Updates to Kaguya TC big PR based on comments * Update kaguyatc2isis.xml Replace tab with spaces. * Fix spacing * Updated comment for clarity * Move comment

* tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint (#3146) * Fix time-formatting in reingested CaSSIS images. (#3149) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added LineEqationTests.cpp (#3152) * History entry added to cube after running sumspice. Fixes #4972. (#658) * Added WriteHistory() method to SumFinder. * Renamed method. * Refactored writeHistory to be up to isis standards. * Added history entries and updated code to be up to isis standards. * Updated history entry. * Various minor mods to the readme (#3165) * Added FileList test (#3168) * Added LineEqationTests.cpp * Added FileListTests.cpp Implemented an istream constructor in FileList.cpp to help with testing. * added FileList tests. implemented istream constructor for FileList.cpp to help with testing. * fixed whitespace issues in FileListTests.cpp * Update FileListTests.cpp * Cleaned up data area wording in install guide (#3170) * Add ISIS3 update instructions to README (#3175) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * Updating Contributing.md (#3179) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * updated contributing guidelines * removed mentions of TC * Added LatitudeTest using Gtest (#3160) * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. * Created LatitudeTests. * Added C-Shell variable setup (#3173) * Added C-Shell variable setup * Fixed history * Made a bit more pythonic * Updates BulletDSKShape's methods for multisegment DSKs (#3181) * fixed DSK segment methods * fixed some errors * added contraints * fixed bug where an extra segment was added * Fixed memory leak in Bullet shape model (#3180) * Added AffineTests (#3166) * Add Longitude gtest (rebase of #601) (#3182) * Created gtest for Longitude class * Remove old Longitude test * Fix syntax for Longitude Tests * Remove comment * Revert "Remove old Longitude test" This reverts commit 608d3fd5c32d7e4a1de7fec407697a0147fbfae0. * Cleaned file, organzied test cases * Fixed failing copy constructor test * Fixed bug where findrx was not adding a history blob to the input cube (#3186) * Added writeHistory to findrx. * Rearranged includes in findrx. * Removed extra exceptions writing controlnets (#3185) * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed, References #2591). (#3193) * updates to ControlPoint::ComputeApriori * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed (References #2591). Added check to IsConstrained() method to see if point type is Free, in which case we ignore stored a priori sigmas on the coordinates. * added isis error when GenericTransform::calculateInverse gets empty matrix (#3195) * Writing 0 Value Residuals to PVL (#3194) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixing errors introduced with the changes to ProcessExportPds4.cpp for the tgo sprint. (#3202) * Github/Discuss Documentation Update (#3203) * Updated website documentation to point to github and discuss where appropriate * Updated last install link * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and tru… (#3200) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Update README.md (#3204) Updated to include instructions for release candidate builds on anaconda * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release (#3254) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release * Fixing date on version file * Added GaussianDistribution Tests (#3221) * Added GaussianDistribution Test. * Removed unused method and added test for exception. * Changed comment. * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release (#3254) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release * Fixing date on version file * Put the Probability method back and removed the old unit test and truth data. * Changed FeatureAlgorithmFactory.cpp to allow pathnames in the algorithm parameter. (Adresses issue #2474) (#3270) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * changed formatSpecifications function to ignore pathnames when splitting the algorithm parameter. * added history comment to FeatureAlgorithmFactory header file * more changes to history in header file * Changes for de430 (#3283) * Removes patchelf; Fixes 3136 (#3265) * Removes patchelf * Removes patchelf from gcc4 as well * changed support href to github issues link (#3287) * Updated pull request for Statistics.cpp test to adhere to recommendations. (#3291) * Unit Test for Statistics object. * Added changes based on comments from PR. Added test for XML serialization read/write. * Changed special pixel type declarations to more readable Hrs,Lrs,Lis,His,.... * Updated pull request for StatisticsTest to adhere to recommendations * renamed Statistics.cpp test to StatisticsTest.cpp * Ticked version number (#3294) * Updated build meta.yaml (#3295) * Updated for 3.7.1 release ... again (#3303) * Added odyssey cat test. (#3307) * Added mex cat test. (#3309) * Updated tolerance for thmproc vis test after false positive test failures (#3315) * update release version (#3316) * Updated csvdiff to python3 (#3319) * Hayabusa2 cat test (#3304) * Added cat test for hayabusa2 * Updated campt calls and removed cub * Pipeline Test Update (#3321) * Updated pipeline to use TestPreferences where necessary * Updated pipeline truth data * Made preference parameter position consistant * Updated pipeline truth data again * Add Kaguya TC support to ISIS (#3240) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Update unit test for Kaguya TC to match output of updated camera model (#3241) * Merge dev info kaguyatc (#3243) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update kaguyatc branch from dev (#3245) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Moddified description (#3246) * updates for review comments (#3277) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Updates to Kaguya TC big PR based on comments * Update kaguyatc2isis.xml Replace tab with spaces. * Fix spacing * Updated comment for clarity * Move comment * Update chandrayaan1 test data for switch to use base lro dem (#3322) * Fixed caminfo csv test Makefile sed to remove isis version and date (#3325) * Remove "kernels can be excluded" from README.md (#3329) Fixed a small typo, reworded a paragraph, and then removed "(kernels can be excluded)" from the description of how to download data for each mission. It was present for _each mission_, so including (kernels can be excluded) didn't communicate any real, mission-specific information. The paragraph above the mission-specific data downloads explains that the kernels can be excluded unless a mission-specific calibration program or end-to-end program needs them and directs the reader to consult mission-specific documentation. * Add sensor model support for Calibrated VIRTIS_M_IR and VIRTIS_M_VIS images to ISIS (#647) * Fixes the reading of SCETs into the ISIS3 table in the ingested image for level-3, calibrated VIRTIS-M images * Added initial updates to the RosettaVirtisCamera model to support VIRTIS-M calibrated images * Corrected StartTime and SpacecraftClockStartCount in calibrated VIRTIS-M ingested images and initial camera model cleanup * Fix spacecraft clock start / stop count and start time and stop time in rosetta virtis labels * Updated label fix for rosvirtis2isis. * fixed StopTime and SpacecraftClockStopCount in virtis labels * Cleanup of camera model * Fix sclk calculation in rosvirtis2isis, update table attached to ingested cube to include the sclk string, update camera model to use updated table. * Changes to the RosettaVirtisCamera and SpiceRotation to allow spiceinit with mirror kernels * Clean up debug output * Update SpiceRotation's minimize-cache-status setting function to not update if it has been previously set to fixed * Update SpiceRotation to only set the time cache explicitly if one has not already been loaded from the InstrumentPosition table attached to the cube * Clean up rosetta virtis changes * Cleanup of merge of virtis changes * Minor Update to Fix Voyager Bundle Adjustment (#3343) * Added argument to CameraGroundMap::GetXY to allow back-of-planet test to be skipped for the bundle adjust * Added ability to turn off back-of-planet test while iterating in a bundle adjust * Replaced DBL_EPSILON as a testing constant for valid distances and angles in SurfacePoint. * Corrected a bool check in CameraGroundMap::GetXY * Virtis level 2 ingestion fix (#3347) * Update date and other metadata * Fix level 2 virtis ingestion * Fix accidental merge with 3.7? * Updates for 3.8.0_RC1 (#3349) * Fix ckwriter failing test - update to use fixed kernels aside from the sclks (#3350) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Fix for 3.8 (#3354) * Fixes failing Rosetta VIRTIS Camera Model test (#3355) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Update Rosetta VIRTIS test to test the calibrated (level 3) data supported by the camera model and test both VIS and IR * Wrong version of GSL (#3359) Based on the file environment.yml in this repository, the GSL version used is 2.2.1. Yet CMakeLists.txt insists on version 19. That is wrong. The latest stable release of GSL is 2.5. Maybe there 1.9 was meant. In either case, apparently this version number is ignored anyway, the only reason I found out is when I switched from your homegrown isis/cmake/FindGSL.cmake when does not use the version in its logic to miniconda3/envs/isis3/share/cmake-3.11/Modules/FindGSL.cmake which does. * Updates qmos to fix grid-drawing if LongitudeDirection is PositiveWest (#3368) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Swaps min/max longitude for PositiveWest * Remove debug comment * Updated cisscal label output (#3375) * Updated cisscal to output the version of cisscal that ISIS has ported over * Added history to cisscal xml * Improved voycal error messages (#3373) * Testing updates for Jenkins and MRO (#3380) * updated tests to get them passing in different OSes * removed bad program launcher test * tracking table except fix * missed PDS table file * typo * added colon * tracking table test updated * Changed FileName to use US English for date conversions (#3379) * Changed FileName to use US English for date conversions * Removed defaulte locale * Fixed FileList test * Fixes 3382 Removes mention of redmine. Fixes #3382. * add fish support * Removed grep from Makefile and added Program to diff file. (#3393) * Update isis3VarInit.py (#3392) fix paste bug * Update kerneldbgen to work with spks with many time intervals (#3386) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated spk max window size to 200000 to accomodate large smithed spks * fix size to be consistent * Removed redundant find scripts (#3394) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * Set the buffer size to the area being worked instead of 1x1 (#3381) * Modifying how ProcessRubberSheet::transformPatch() handles buffers. * Updated a comment to reflect the new way * Fix for slight diff in DNs at edge of image for cam2map * Add to a comment * Removed comments and moved tests so they trigger sooner * removed email message from DawnFcCamera (#3397) * Findfeatures (#3399) * Changed match function in Matchmaker to pass in copies of pointers * Revert "Changed match function in Matchmaker to pass in copies of pointers" This reverts commit f687eb668f4438245572a0c6a62b50b64846a12f. * updated match method in MatchMaker to pass in clones of pointers * Added the ability to pass lists instead of directories and filters to kerneldbgen (#3398) * Added file list option to spicedbgen * First pass at actual params * Fixed scoping error * Updated no parameters selected check * Added historty comment to SpiceDbGen * Fixed weird type logic * added error for level 2 input cube * Simplifies Jenkinsfile for webhook testing (#3403) * made RELEASE mode default, added debug optimization flag * Update to CaSSIS Exported PDS4 images and Mosaicking program (#3402) * Update date and other metadata * Added changes to tgo-related applications and PEP4 to update PDS4 exported labels for CaSSIS based on requests * Updated tgocassisrdrgen to add PSA schema * Add function on cube to return actual min/max lat/lons based on DNs and updated PEP4 to format a couple of specific output map values with a trailing .0. Also update PEP4 to use the new function on Cube to calculate min/max lat/lons * Fixed description order, updated geom schema details to pass validation, propagate Archive group to mosaic output needed for PDS4 export * Update to PEP4 * Update tgocassisrdrgen * Cleanup before commit * More cleanup add header file history entries * Clean up PEP4 before commit * Updates to address review comments * Patch jenkinsfile (#3407) * Simplifies Jenkinsfile for webhook testing * Updates to how bundleout.txt is being written cont'd. (#3404) * Added column/unit descriptions to image header in outputHeader(...) function. * More changes to clean up the bundleout.txt file. * Added the locations of the cube list file/file_prefix to the bundleout.txt file. * Added bundleOut output function to the BundleObservation class. * Updated BundleObservation::bundleOutput(std::ofstream &fpOut,bool errorPropagation, bool imageCCSV) * Added history entries/function documentation and minor tweaks to BundleSolutionInfo/BundleObservation * Fixed a memory issue associated with attempting to set the output control network for BundleSettingsInfo in jigsaw. * Added reviewer-requested changes. * Added more updates to this PR per Summer's (the reviewer) request. * Fixed some formatting in the parameter list ouput introduced by the refactor of the bundleOutputString function. * Formatting tweaks in BundleSolutionInfo::outputText(...) and BundleObservation::bundleOutputString()... so the columns line-up nicely. * Implemented more changes requested by Summer (the reviewer). * Added BundleObservation::bundleoutCSV()/bundleoutputFetchData() functions. Also changed precision of output, which necessitated formatting changs to the BundleSolutionInfo::outputText() function. Full refactor per Summer's request not completed yet (needs to be tested). * Removed BundleObservation::formatBundleOutputString and all references to it in ISIS3. * Minor formatting changes requested by reviewers. * Cleaning-up code and logic for changes made for bundleout.txt * Adding logic to fix incorrect values in bundleout.txt * Updated cisscal to output the version of cisscal that ISIS has ported over * Added history to cisscal xml * Fixing failing unit tests for bundleout logic. * Minor reversal of modification to BundleObservation.cpp * Minor typo fixes before PR creation * Cleaning-up the output code as per reviewer request * Added back in old formatBundleOutputString function * Added deprication message for the old bundle output formatter * Addressed PR comments * Fixes failing tgo cat tests and PEP4 unitTest (#3408) * Update date and other metadata * Added changes to tgo-related applications and PEP4 to update PDS4 exported labels for CaSSIS based on requests * Updated tgocassisrdrgen to add PSA schema * Add function on cube to return actual min/max lat/lons based on DNs and updated PEP4 to format a couple of specific output map values with a trailing .0. Also update PEP4 to use the new function on Cube to calculate min/max lat/lons * Fixed description order, updated geom schema details to pass validation, propagate Archive group to mosaic output needed for PDS4 export * Update to PEP4 * Update tgocassisrdrgen * Cleanup before commit * More cleanup add header file history entries * Clean up PEP4 before commit * Updates to address review comments * Fix raw image failing tests * Update truthdata for PEP4 * Added oblique resolutions to advanced track tool and the geometry and camstats groups of caminfo output (#3249) (#3288) * Removed oblique resolutions not needed in the Advanced Track Tool and added oblique res max/min to camstats group. * Pulled down branch and made changes to documentaiton. * Changed documentation. * updated documentation. * Quick fixes. * Deleted old caminfo.cpp * Fixes 3410 - Question template improvement (#3411) * Fixes 3410 * Update 3_Support_question.md * Bundle Output Test Update (#3414) * Rebased off of dev * Reset bundleObservation cpp * Removed duplicate outputs * Updates deltack tests with bundle changes * Changed cube sample and line loop to double (#3421) * Updated Bundle Utilities truth data * Allows user control of output bit type in hideal2pds. Added for tjwilson. #2692 #3366 (#3420) * Allows user control of output bit type. Added for tjwilson * Updated no global variables, indents * Fixed race condition in FileName test * Updated cisscal to match IDL version 3.9.1 (#3406) * Removed grep from Makefile and added Program to diff file. * Updated cisscall to IDL version 3.9. * Fixed typo. * Updated to version 3.9.1. * Updated documentation. * Updated version number. * Fixed CissLabels unit test. (#3428) * Fixed mac build error. * Updates for 3.9.0 RC (#3431) * Fixed optimization flag for Linux and added -g for debug builds * Bundleout Reformat (#3447) * Updated bundle text output to match expected output * Further formatting for the bundle text output * Added history comments * Reformat of RMS output in bundleout.txt * Updated BundleSolutionInfo unittest * Updated version to 3.9.0_RC1 (#3448) * Fixed compiler warnings. Fixes #3418, Fixes #3198 (#3459) * Updated version to 3.9.0_RC1 * Removed compiler warnings with as few changes as possible * Updated pvldiff to support PvlContainers with unequal keyword lengths (#3460) * Updated pvldiff to support PvlContainers with unequal keyword lengths with IngoreKeys * groups now remove keys as well * Added Anaconda cloud badge (#3463) * Ale integration into dev (#3464) * Adds Ale into isis env (#3437) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * remove load call * reordered env.yml * reordered env * unpinned more stuff * updated cmakelists * Naif Keywords/SpicePosition/SpiceRotation now obtained from Ale label and not Spice kernels on Spiceinit (#3442) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * Adding spiceinit classic as back up to Ale implementation. (#3458) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * added back ISIS spiceinit classic as a backup to ale * added source keyword to Kernels group * kernel group now added only in spiceinit * updates as per comments * Matrix p_cache (#3461) * Converted quaternion into matrix when pushing onto the p_cache * Removed extra print * Tests docs (#3467) * Reverted Blob change * Added doc strings * Moved usage into source files * Added SpicePosition test * changed thread inc to target * Updated SpicePoition unitTest * Added SpiceRotation unit test * Updated SpiceRotation truth * Update README.md fixes a white space formatting issue in step 7 which prevented a portion of the documentation being rendered correctly * Correct documentation. The file written to the path specified by CNETFILE will be in binary control network format, not plain-text PVL format. The incorrect description in this documentation has been incorrect for at least 7 years, based on the 'Blame' view of the relevant lines in hijitreg/main.cpp, ControlNet/ControlNet.h, and ControlNet/ControlNet.cpp. * Revert "Ale integration into dev (#3464)" This reverts commit 48e4efd1babab7e9608ec15cd4030cc7f51d66c2. * Converted PixelType unit test to gtest (#3478) * converted Pixel type unit test to gtest * removed old unit test and truth data * converted Column unit test to gtest (#3480) * converted Column unit test to gtest * removed redundant tests * Added Working BundleMeasure gtest File (#3470) * Initial Stab at BundleMeasureTest with Fixtures. * Added Working BundleMeasure gtest File * Added a refernce to phocube to camdev docs * Fixes Qmos grid to properly consider PositiveWest and PositiveEast (#3488) * Fixes Qmos grid to properly consider PositiveWest and PositiveEast * clean up * update as per comments * added comments on positive west angles as they come into the GridGraphicsItem constructor * Bundleout Text file update (#3485) * Initial changes to get the bundleout into a better place * Added a few comments and updated how the spacing for the sprintfs is obtained * Reverted unnecessary changes to BundleObservation * Updated file path length checking as suggested * Updates voy2isis to add an optional parameter to specify the instrument name (#3490) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Warning for photomet added (#3486) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * Addressing Stuarts comments * Addressing Kristin's comment * Updating Kaguya Distortion Model with Boresight (Finishing #3492) (#3498) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * changes to KaguyaTC distortion map * Fixed test on Aarons PR * updated unit test * reseting test data location * Adding camera uptick * Replaced code, removed earlier, that abandons work on a tile Fixes: #3466 (#3497) * Replaced code, removed earlier, that abondons work on a tile when it is outside the output image * Typo * Cisscal Output Change (#3496) * Updated cisscal output cub creation to after bitweight correction and dark subtraction * Updated history in cisscal app xml * Added issue number * Added new test for cisscal * Typo * Removed cube when an exception is thrown rather than moving the instantiation point * Austin Sander's "clemhirescal: Adds support for all MCP gain settings for filters A and D" (#3503) * Added support for all MCP gain settings. Closes #3190 * Revised comments to better reflect updated logic * Added history comment. * Added additional description and link to Robinson paper. * added issue number * Added dynamic creation of version file (#3502) * Added dynamic creation of version file * removed commented line * Update README.md * Updates marci2isis to add variable exposure times and associated frame sequences (#3501) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Updated to reverse frameseq number appropriately with flip * Remove commented-out code * Added documentation for change and test * Updated no exposure duration in varexp file condition * Re-remove iTime.h * Update warning message for assuming a single exposure time * Modified to use the frame and exposure keywords added by marci2isis i… (#3505) * Modified to use the frame and exposure keywords added by marci2isis instead of the varexp.tab file * Added the issue that caused this to need to be fixed * Update main.cpp * Updated Readme with Contributing link * Jenkins Build Script update (#3533) * Updated pipeline to use TestPreferences where necessary * Updated pipeline truth data * Made preference parameter position consistant * Updated pipeline truth data again * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Changed testing avoid which failure * Removed echo * Pointed at install bin instead of build bin * Added a forgotten / * Added the actual install directory * Changed isisroot to point to install directory * More tweeks to the groovy script * Removed conda prefix echo * Moved path update to a single line * new groove * new groove * new groove * new groove * new groove * Updated spice rotation test with isis variable * Testing with appjit * Only testing app jit * Changed app test to -R * More messing with stuffs * Added check for catlab * Changed install directory location * Changed paths again * Echoed pwd in checkout * Retry the print * Pathing one more time * Paths * updated build.groovy * Update Jenkinsfile (#3525) * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * fixed compiler warning. Fixes #3531 * Update kerneldbgen test to handle input file path edge case (#3536) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated kerneldbgen test to deal with specific filepath length edge case * Updated groovy to use new Kakadu include (#3537) * Updated groovy to use new Kakadu include * Fixed typo in include path * changed cisscal to no longer use absolute paths (#3541) * excluded file group now prints original file * Added preferences variable to shapemodel path. * Update failing kerneldbgen ck test again (#3540) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated kerneldbgen test to deal with specific filepath length edge case * Update kerneldbgen ck test to use IgnoreFilePaths * Removed requirement of having to start a path with a slash, and added the dollar sign to the regex to allow the ignorepath feature to ignore file paths that start with an environment or isis variable * Updating test and truth data to print relative file (#3545) * Minor updates to "How to Write Documentation" documentation (#3510) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Minor updates to How to Write Documentation documentation to reflect build changes post-cmake * remove additionally as per review comments * Adding just the meta.yml, previous PR updated CMakeLists.txt (#3549) * Moved deactivates outside of the try block, also added an env clean up step (#3556) * Jenkins Changes (#3557) * Jenkins file update to make use of the web hook * Added a groovy utilities file * Changed the pipeline to load the right file * Updated the name of the groovy file * Removed unnecessary isis app -help commands * Copy the header files on install (#3565) * Copy the header files on install * Update CMakeLists.txt * Added flag to skip SSL verification in CI (#3572) * Added flag to skip SSL verification on PR CI * Added no SSL flag to nightly build script * Update Jenkinsfile * Update build.groovy * Update build.groovy * Update Jenkinsfile * Added command to skip SSL verification in Anaconda * Updated build.groovy with anaconda SSL flag * Merging ALE into dev (#3590) * Adds Ale into isis env (#3437) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * remove load call * reordered env.yml * reordered env * unpinned more stuff * updated cmakelists * Naif Keywords/SpicePosition/SpiceRotation now obtained from Ale label and not Spice kernels on Spiceinit (#3442) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * Adding spiceinit classic as back up to Ale implementation. (#3458) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * added back ISIS spiceinit classic as a backup to ale * added source keyword to Kernels group * kernel group now added only in spiceinit * updates as per comments * Matrix p_cache (#3461) * Converted quaternion into matrix when pushing onto the p_cache * Removed extra print * Tests docs (#3467) * Reverted Blob change * Added doc strings * Moved usage into source files * Added SpicePosition test * changed thread inc to target * Updated SpicePoition unitTest * Added SpiceRotation unit test * Updated SpiceRotation truth * Merging Dev into ale_integration (#3552) * Fixed optimization flag for Linux and added -g for debug builds * Bundleout Reformat (#3447) * Updated bundle text output to match expected output * Further formatting for the bundle text output * Added history comments * Reformat of RMS output in bundleout.txt * Updated BundleSolutionInfo unittest * Updated version to 3.9.0_RC1 (#3448) * Fixed compiler warnings. Fixes #3418, Fixes #3198 (#3459) * Updated version to 3.9.0_RC1 * Removed compiler warnings with as few changes as possible * Updated pvldiff to support PvlContainers with unequal keyword lengths (#3460) * Updated pvldiff to support PvlContainers with unequal keyword lengths with IngoreKeys * groups now remove keys as well * Added Anaconda cloud badge (#3463) * Ale integration into dev (#3464) * Adds Ale into isis env (#3437) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * remove load call * reordered env.yml * reordered env * unpinned more stuff * updated cmakelists * Naif Keywords/SpicePosition/SpiceRotation now obtained from Ale label and not Spice kernels on Spiceinit (#3442) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * Adding spiceinit classic as back up to Ale implementation. (#3458) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * added back ISIS spiceinit classic as a backup to ale * added source keyword to Kernels group * kernel group now added only in spiceinit * updates as per comments * Matrix p_cache (#3461) * Converted quaternion into matrix when pushing onto the p_cache * Removed extra print * Tests docs (#3467) * Reverted Blob change * Added doc strings * Moved usage into source files * Added SpicePosition test * changed thread inc to target * Updated SpicePoition unitTest * Added SpiceRotation unit test * Updated SpiceRotation truth * Update README.md fixes a white space formatting issue in step 7 which prevented a portion of the documentation being rendered correctly * Correct documentation. The file written to the path specified by CNETFILE will be in binary control network format, not plain-text PVL format. The incorrect description in this documentation has been incorrect for at least 7 years, based on the 'Blame' view of the relevant lines in hijitreg/main.cpp, ControlNet/ControlNet.h, and ControlNet/ControlNet.cpp. * Revert "Ale integration into dev (#3464)" This reverts commit 48e4efd1babab7e9608ec15cd4030cc7f51d66c2. * Converted PixelType unit test to gtest (#3478) * converted Pixel type unit test to gtest * removed old unit test and truth data * converted Column unit test to gtest (#3480) * converted Column unit test to gtest * removed redundant tests * Added Working BundleMeasure gtest File (#3470) * Initial Stab at BundleMeasureTest with Fixtures. * Added Working BundleMeasure gtest File * Added a refernce to phocube to camdev docs * Fixes Qmos grid to properly consider PositiveWest and PositiveEast (#3488) * Fixes Qmos grid to properly consider PositiveWest and PositiveEast * clean up * update as per comments * added comments on positive west angles as they come into the GridGraphicsItem constructor * Bundleout Text file update (#3485) * Initial changes to get the bundleout into a better place * Added a few comments and updated how the spacing for the sprintfs is obtained * Reverted unnecessary changes to BundleObservation * Updated file path length checking as suggested * Updates voy2isis to add an optional parameter to specify the instrument name (#3490) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Warning for photomet added (#3486) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * Addressing Stuarts comments * Addressing Kristin's comment * Updating Kaguya Distortion Model with Boresight (Finishing #3492) (#3498) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * changes to KaguyaTC distortion map * Fixed test on Aarons PR * updated unit test * reseting test data location * Adding camera uptick * Replaced code, removed earlier, that abandons work on a tile Fixes: #3466 (#3497) * Replaced code, removed earlier, that abondons work on a tile when it is outside the output image * Typo * Cisscal Output Ch…

* Fixed bug where findrx was not adding a history blob to the input cube (#3186) * Added writeHistory to findrx. * Rearranged includes in findrx. * Removed extra exceptions writing controlnets (#3185) * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed, References #2591). (#3193) * updates to ControlPoint::ComputeApriori * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed (References #2591). Added check to IsConstrained() method to see if point type is Free, in which case we ignore stored a priori sigmas on the coordinates. * added isis error when GenericTransform::calculateInverse gets empty matrix (#3195) * Writing 0 Value Residuals to PVL (#3194) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixing errors introduced with the changes to ProcessExportPds4.cpp for the tgo sprint. (#3202) * Github/Discuss Documentation Update (#3203) * Updated website documentation to point to github and discuss where appropriate * Updated last install link * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and tru… (#3200) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Update README.md (#3204) Updated to include instructions for release candidate builds on anaconda * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release (#3254) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release * Fixing date on version file * Added GaussianDistribution Tests (#3221) * Added GaussianDistribution Test. * Removed unused method and added test for exception. * Changed comment. * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release (#3254) * Modifying meta.yaml and version files for ISIS3.7.0 Public Release * Fixing date on version file * Put the Probability method back and removed the old unit test and truth data. * Changed FeatureAlgorithmFactory.cpp to allow pathnames in the algorithm parameter. (Adresses issue #2474) (#3270) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * changed formatSpecifications function to ignore pathnames when splitting the algorithm parameter. * added history comment to FeatureAlgorithmFactory header file * more changes to history in header file * Changes for de430 (#3283) * Removes patchelf; Fixes 3136 (#3265) * Removes patchelf * Removes patchelf from gcc4 as well * changed support href to github issues link (#3287) * Updated pull request for Statistics.cpp test to adhere to recommendations. (#3291) * Unit Test for Statistics object. * Added changes based on comments from PR. Added test for XML serialization read/write. * Changed special pixel type declarations to more readable Hrs,Lrs,Lis,His,.... * Updated pull request for StatisticsTest to adhere to recommendations * renamed Statistics.cpp test to StatisticsTest.cpp * Ticked version number (#3294) * Updated build meta.yaml (#3295) * Updated for 3.7.1 release ... again (#3303) * Added odyssey cat test. (#3307) * Added mex cat test. (#3309) * Updated tolerance for thmproc vis test after false positive test failures (#3315) * update release version (#3316) * Updated csvdiff to python3 (#3319) * Hayabusa2 cat test (#3304) * Added cat test for hayabusa2 * Updated campt calls and removed cub * Pipeline Test Update (#3321) * Updated pipeline to use TestPreferences where necessary * Updated pipeline truth data * Made preference parameter position consistant * Updated pipeline truth data again * Add Kaguya TC support to ISIS (#3240) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Update unit test for Kaguya TC to match output of updated camera model (#3241) * Merge dev info kaguyatc (#3243) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update kaguyatc branch from dev (#3245) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Moddified description (#3246) * updates for review comments (#3277) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added base for KaguyaTcCamera * Still adding to base * additonal changes * Added appropriate ckframeid * Fixed improper makefile * Added unitTest.cpp to KaguyaTcCamera * Adding camera plugin and test. * Update camera plugin. * Added working unit test. Added naif ck ID to ingestion. * Changed camera parent class to LineScanCamera * Add a Distortion Model to Kaguya TC ISIS camera model (#3215) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Update Kaguya TC Camera model to use LineScan Camera detector map (#3218) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Fixes GroundMap, SkyMap in Kaguya TC Camera Model and improve Focal Map Origin (#3220) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update Kaguya TC Camera Model to include Detector offsets for swath modes (#3222) * Initial distortion model changes * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Change camera model to pull the Origin from the IAK * Update Kaguya TC camera model time and add option to Spice::getClockTime (#3237) * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Initial distortion model changes * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Distortion model updates to actually match equation in documentation * Update truthdata for sensor model * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Switch Kaguya TC to use L/S camera detector map. It is not a framer! * Fix typo * Update detector origin in Kaguya TC model to be more reasonable * Update to center position and offsets for distortion map swath modes added to Kaguya TC Camera Model * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Updated the time used by the camera model to use the clock count, rather than the start time * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Update unit test for Kaguya TC to match output of updated camera model * Updates to Kaguya TC big PR based on comments * Update kaguyatc2isis.xml Replace tab with spaces. * Fix spacing * Updated comment for clarity * Move comment * Update chandrayaan1 test data for switch to use base lro dem (#3322) * Fixed caminfo csv test Makefile sed to remove isis version and date (#3325) * Remove "kernels can be excluded" from README.md (#3329) Fixed a small typo, reworded a paragraph, and then removed "(kernels can be excluded)" from the description of how to download data for each mission. It was present for _each mission_, so including (kernels can be excluded) didn't communicate any real, mission-specific information. The paragraph above the mission-specific data downloads explains that the kernels can be excluded unless a mission-specific calibration program or end-to-end program needs them and directs the reader to consult mission-specific documentation. * Add sensor model support for Calibrated VIRTIS_M_IR and VIRTIS_M_VIS images to ISIS (#647) * Fixes the reading of SCETs into the ISIS3 table in the ingested image for level-3, calibrated VIRTIS-M images * Added initial updates to the RosettaVirtisCamera model to support VIRTIS-M calibrated images * Corrected StartTime and SpacecraftClockStartCount in calibrated VIRTIS-M ingested images and initial camera model cleanup * Fix spacecraft clock start / stop count and start time and stop time in rosetta virtis labels * Updated label fix for rosvirtis2isis. * fixed StopTime and SpacecraftClockStopCount in virtis labels * Cleanup of camera model * Fix sclk calculation in rosvirtis2isis, update table attached to ingested cube to include the sclk string, update camera model to use updated table. * Changes to the RosettaVirtisCamera and SpiceRotation to allow spiceinit with mirror kernels * Clean up debug output * Update SpiceRotation's minimize-cache-status setting function to not update if it has been previously set to fixed * Update SpiceRotation to only set the time cache explicitly if one has not already been loaded from the InstrumentPosition table attached to the cube * Clean up rosetta virtis changes * Cleanup of merge of virtis changes * Minor Update to Fix Voyager Bundle Adjustment (#3343) * Added argument to CameraGroundMap::GetXY to allow back-of-planet test to be skipped for the bundle adjust * Added ability to turn off back-of-planet test while iterating in a bundle adjust * Replaced DBL_EPSILON as a testing constant for valid distances and angles in SurfacePoint. * Corrected a bool check in CameraGroundMap::GetXY * Virtis level 2 ingestion fix (#3347) * Update date and other metadata * Fix level 2 virtis ingestion * Fix accidental merge with 3.7? * Updates for 3.8.0_RC1 (#3349) * Fix ckwriter failing test - update to use fixed kernels aside from the sclks (#3350) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Fix for 3.8 (#3354) * Fixes failing Rosetta VIRTIS Camera Model test (#3355) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Update Rosetta VIRTIS test to test the calibrated (level 3) data supported by the camera model and test both VIS and IR * Wrong version of GSL (#3359) Based on the file environment.yml in this repository, the GSL version used is 2.2.1. Yet CMakeLists.txt insists on version 19. That is wrong. The latest stable release of GSL is 2.5. Maybe there 1.9 was meant. In either case, apparently this version number is ignored anyway, the only reason I found out is when I switched from your homegrown isis/cmake/FindGSL.cmake when does not use the version in its logic to miniconda3/envs/isis3/share/cmake-3.11/Modules/FindGSL.cmake which does. * Updates qmos to fix grid-drawing if LongitudeDirection is PositiveWest (#3368) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Swaps min/max longitude for PositiveWest * Remove debug comment * Updated cisscal label output (#3375) * Updated cisscal to output the version of cisscal that ISIS has ported over * Added history to cisscal xml * Improved voycal error messages (#3373) * Testing updates for Jenkins and MRO (#3380) * updated tests to get them passing in different OSes * removed bad program launcher test * tracking table except fix * missed PDS table file * typo * added colon * tracking table test updated * Changed FileName to use US English for date conversions (#3379) * Changed FileName to use US English for date conversions * Removed defaulte locale * Fixed FileList test * Fixes 3382 Removes mention of redmine. Fixes #3382. * add fish support * Removed grep from Makefile and added Program to diff file. (#3393) * Update isis3VarInit.py (#3392) fix paste bug * Update kerneldbgen to work with spks with many time intervals (#3386) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated spk max window size to 200000 to accomodate large smithed spks * fix size to be consistent * Removed redundant find scripts (#3394) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * Set the buffer size to the area being worked instead of 1x1 (#3381) * Modifying how ProcessRubberSheet::transformPatch() handles buffers. * Updated a comment to reflect the new way * Fix for slight diff in DNs at edge of image for cam2map * Add to a comment * Removed comments and moved tests so they trigger sooner * removed email message from DawnFcCamera (#3397) * Findfeatures (#3399) * Changed match function in Matchmaker to pass in copies of pointers * Revert "Changed match function in Matchmaker to pass in copies of pointers" This reverts commit f687eb668f4438245572a0c6a62b50b64846a12f. * updated match method in MatchMaker to pass in clones of pointers * Added the ability to pass lists instead of directories and filters to kerneldbgen (#3398) * Added file list option to spicedbgen * First pass at actual params * Fixed scoping error * Updated no parameters selected check * Added historty comment to SpiceDbGen * Fixed weird type logic * added error for level 2 input cube * Simplifies Jenkinsfile for webhook testing (#3403) * made RELEASE mode default, added debug optimization flag * Update to CaSSIS Exported PDS4 images and Mosaicking program (#3402) * Update date and other metadata * Added changes to tgo-related applications and PEP4 to update PDS4 exported labels for CaSSIS based on requests * Updated tgocassisrdrgen to add PSA schema * Add function on cube to return actual min/max lat/lons based on DNs and updated PEP4 to format a couple of specific output map values with a trailing .0. Also update PEP4 to use the new function on Cube to calculate min/max lat/lons * Fixed description order, updated geom schema details to pass validation, propagate Archive group to mosaic output needed for PDS4 export * Update to PEP4 * Update tgocassisrdrgen * Cleanup before commit * More cleanup add header file history entries * Clean up PEP4 before commit * Updates to address review comments * Patch jenkinsfile (#3407) * Simplifies Jenkinsfile for webhook testing * Updates to how bundleout.txt is being written cont'd. (#3404) * Added column/unit descriptions to image header in outputHeader(...) function. * More changes to clean up the bundleout.txt file. * Added the locations of the cube list file/file_prefix to the bundleout.txt file. * Added bundleOut output function to the BundleObservation class. * Updated BundleObservation::bundleOutput(std::ofstream &fpOut,bool errorPropagation, bool imageCCSV) * Added history entries/function documentation and minor tweaks to BundleSolutionInfo/BundleObservation * Fixed a memory issue associated with attempting to set the output control network for BundleSettingsInfo in jigsaw. * Added reviewer-requested changes. * Added more updates to this PR per Summer's (the reviewer) request. * Fixed some formatting in the parameter list ouput introduced by the refactor of the bundleOutputString function. * Formatting tweaks in BundleSolutionInfo::outputText(...) and BundleObservation::bundleOutputString()... so the columns line-up nicely. * Implemented more changes requested by Summer (the reviewer). * Added BundleObservation::bundleoutCSV()/bundleoutputFetchData() functions. Also changed precision of output, which necessitated formatting changs to the BundleSolutionInfo::outputText() function. Full refactor per Summer's request not completed yet (needs to be tested). * Removed BundleObservation::formatBundleOutputString and all references to it in ISIS3. * Minor formatting changes requested by reviewers. * Cleaning-up code and logic for changes made for bundleout.txt * Adding logic to fix incorrect values in bundleout.txt * Updated cisscal to output the version of cisscal that ISIS has ported over * Added history to cisscal xml * Fixing failing unit tests for bundleout logic. * Minor reversal of modification to BundleObservation.cpp * Minor typo fixes before PR creation * Cleaning-up the output code as per reviewer request * Added back in old formatBundleOutputString function * Added deprication message for the old bundle output formatter * Addressed PR comments * Fixes failing tgo cat tests and PEP4 unitTest (#3408) * Update date and other metadata * Added changes to tgo-related applications and PEP4 to update PDS4 exported labels for CaSSIS based on requests * Updated tgocassisrdrgen to add PSA schema * Add function on cube to return actual min/max lat/lons based on DNs and updated PEP4 to format a couple of specific output map values with a trailing .0. Also update PEP4 to use the new function on Cube to calculate min/max lat/lons * Fixed description order, updated geom schema details to pass validation, propagate Archive group to mosaic output needed for PDS4 export * Update to PEP4 * Update tgocassisrdrgen * Cleanup before commit * More cleanup add header file history entries * Clean up PEP4 before commit * Updates to address review comments * Fix raw image failing tests * Update truthdata for PEP4 * Added oblique resolutions to advanced track tool and the geometry and camstats groups of caminfo output (#3249) (#3288) * Removed oblique resolutions not needed in the Advanced Track Tool and added oblique res max/min to camstats group. * Pulled down branch and made changes to documentaiton. * Changed documentation. * updated documentation. * Quick fixes. * Deleted old caminfo.cpp * Fixes 3410 - Question template improvement (#3411) * Fixes 3410 * Update 3_Support_question.md * Bundle Output Test Update (#3414) * Rebased off of dev * Reset bundleObservation cpp * Removed duplicate outputs * Updates deltack tests with bundle changes * Changed cube sample and line loop to double (#3421) * Updated Bundle Utilities truth data * Allows user control of output bit type in hideal2pds. Added for tjwilson. #2692 #3366 (#3420) * Allows user control of output bit type. Added for tjwilson * Updated no global variables, indents * Fixed race condition in FileName test * Updated cisscal to match IDL version 3.9.1 (#3406) * Removed grep from Makefile and added Program to diff file. * Updated cisscall to IDL version 3.9. * Fixed typo. * Updated to version 3.9.1. * Updated documentation. * Updated version number. * Fixed CissLabels unit test. (#3428) * Fixed mac build error. * Updates for 3.9.0 RC (#3431) * Fixed optimization flag for Linux and added -g for debug builds * Bundleout Reformat (#3447) * Updated bundle text output to match expected output * Further formatting for the bundle text output * Added history comments * Reformat of RMS output in bundleout.txt * Updated BundleSolutionInfo unittest * Updated version to 3.9.0_RC1 (#3448) * Fixed compiler warnings. Fixes #3418, Fixes #3198 (#3459) * Updated version to 3.9.0_RC1 * Removed compiler warnings with as few changes as possible * Updated pvldiff to support PvlContainers with unequal keyword lengths (#3460) * Updated pvldiff to support PvlContainers with unequal keyword lengths with IngoreKeys * groups now remove keys as well * Added Anaconda cloud badge (#3463) * Ale integration into dev (#3464) * Adds Ale into isis env (#3437) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * remove load call * reordered env.yml * reordered env * unpinned more stuff * updated cmakelists * Naif Keywords/SpicePosition/SpiceRotation now obtained from Ale label and not Spice kernels on Spiceinit (#3442) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * Adding spiceinit classic as back up to Ale implementation. (#3458) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * added back ISIS spiceinit classic as a backup to ale * added source keyword to Kernels group * kernel group now added only in spiceinit * updates as per comments * Matrix p_cache (#3461) * Converted quaternion into matrix when pushing onto the p_cache * Removed extra print * Tests docs (#3467) * Reverted Blob change * Added doc strings * Moved usage into source files * Added SpicePosition test * changed thread inc to target * Updated SpicePoition unitTest * Added SpiceRotation unit test * Updated SpiceRotation truth * Update README.md fixes a white space formatting issue in step 7 which prevented a portion of the documentation being rendered correctly * Correct documentation. The file written to the path specified by CNETFILE will be in binary control network format, not plain-text PVL format. The incorrect description in this documentation has been incorrect for at least 7 years, based on the 'Blame' view of the relevant lines in hijitreg/main.cpp, ControlNet/ControlNet.h, and ControlNet/ControlNet.cpp. * Revert "Ale integration into dev (#3464)" This reverts commit 48e4efd1babab7e9608ec15cd4030cc7f51d66c2. * Converted PixelType unit test to gtest (#3478) * converted Pixel type unit test to gtest * removed old unit test and truth data * converted Column unit test to gtest (#3480) * converted Column unit test to gtest * removed redundant tests * Added Working BundleMeasure gtest File (#3470) * Initial Stab at BundleMeasureTest with Fixtures. * Added Working BundleMeasure gtest File * Added a refernce to phocube to camdev docs * Fixes Qmos grid to properly consider PositiveWest and PositiveEast (#3488) * Fixes Qmos grid to properly consider PositiveWest and PositiveEast * clean up * update as per comments * added comments on positive west angles as they come into the GridGraphicsItem constructor * Bundleout Text file update (#3485) * Initial changes to get the bundleout into a better place * Added a few comments and updated how the spacing for the sprintfs is obtained * Reverted unnecessary changes to BundleObservation * Updated file path length checking as suggested * Updates voy2isis to add an optional parameter to specify the instrument name (#3490) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Warning for photomet added (#3486) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * Addressing Stuarts comments * Addressing Kristin's comment * Updating Kaguya Distortion Model with Boresight (Finishing #3492) (#3498) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * changes to KaguyaTC distortion map * Fixed test on Aarons PR * updated unit test * reseting test data location * Adding camera uptick * Replaced code, removed earlier, that abandons work on a tile Fixes: #3466 (#3497) * Replaced code, removed earlier, that abondons work on a tile when it is outside the output image * Typo * Cisscal Output Change (#3496) * Updated cisscal output cub creation to after bitweight correction and dark subtraction * Updated history in cisscal app xml * Added issue number * Added new test for cisscal * Typo * Removed cube when an exception is thrown rather than moving the instantiation point * Austin Sander's "clemhirescal: Adds support for all MCP gain settings for filters A and D" (#3503) * Added support for all MCP gain settings. Closes #3190 * Revised comments to better reflect updated logic * Added history comment. * Added additional description and link to Robinson paper. * added issue number * Added dynamic creation of version file (#3502) * Added dynamic creation of version file * removed commented line * Update README.md * Updates marci2isis to add variable exposure times and associated frame sequences (#3501) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Updated to reverse frameseq number appropriately with flip * Remove commented-out code * Added documentation for change and test * Updated no exposure duration in varexp file condition * Re-remove iTime.h * Update warning message for assuming a single exposure time * Modified to use the frame and exposure keywords added by marci2isis i… (#3505) * Modified to use the frame and exposure keywords added by marci2isis instead of the varexp.tab file * Added the issue that caused this to need to be fixed * Update main.cpp * Updated Readme with Contributing link * Jenkins Build Script update (#3533) * Updated pipeline to use TestPreferences where necessary * Updated pipeline truth data * Made preference parameter position consistant * Updated pipeline truth data again * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Changed testing avoid which failure * Removed echo * Pointed at install bin instead of build bin * Added a forgotten / * Added the actual install directory * Changed isisroot to point to install directory * More tweeks to the groovy script * Removed conda prefix echo * Moved path update to a single line * new groove * new groove * new groove * new groove * new groove * Updated spice rotation test with isis variable * Testing with appjit * Only testing app jit * Changed app test to -R * More messing with stuffs * Added check for catlab * Changed install directory location * Changed paths again * Echoed pwd in checkout * Retry the print * Pathing one more time * Paths * updated build.groovy * Update Jenkinsfile (#3525) * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * fixed compiler warning. Fixes #3531 * Update kerneldbgen test to handle input file path edge case (#3536) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated kerneldbgen test to deal with specific filepath length edge case * Updated groovy to use new Kakadu include (#3537) * Updated groovy to use new Kakadu include * Fixed typo in include path * changed cisscal to no longer use absolute paths (#3541) * excluded file group now prints original file * Added preferences variable to shapemodel path. * Update failing kerneldbgen ck test again (#3540) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated kerneldbgen test to deal with specific filepath length edge case * Update kerneldbgen ck test to use IgnoreFilePaths * Removed requirement of having to start a path with a slash, and added the dollar sign to the regex to allow the ignorepath feature to ignore file paths that start with an environment or isis variable * Updating test and truth data to print relative file (#3545) * Minor updates to "How to Write Documentation" documentation (#3510) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Minor updates to How to Write Documentation documentation to reflect build changes post-cmake * remove additionally as per review comments * Adding just the meta.yml, previous PR updated CMakeLists.txt (#3549) * Moved deactivates outside of the try block, also added an env clean up step (#3556) * Jenkins Changes (#3557) * Jenkins file update to make use of the web hook * Added a groovy utilities file * Changed the pipeline to load the right file * Updated the name of the groovy file * Removed unnecessary isis app -help commands * Copy the header files on install (#3565) * Copy the header files on install * Update CMakeLists.txt * Added flag to skip SSL verification in CI (#3572) * Added flag to skip SSL verification on PR CI * Added no SSL flag to nightly build script * Update Jenkinsfile * Update build.groovy * Update build.groovy * Update Jenkinsfile * Added command to skip SSL verification in Anaconda * Updated build.groovy with anaconda SSL flag * Merging ALE into dev (#3590) * Adds Ale into isis env (#3437) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * remove load call * reordered env.yml * reordered env * unpinned more stuff * updated cmakelists * Naif Keywords/SpicePosition/SpiceRotation now obtained from Ale label and not Spice kernels on Spiceinit (#3442) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * Adding spiceinit classic as back up to Ale implementation. (#3458) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * added back ISIS spiceinit classic as a backup to ale * added source keyword to Kernels group * kernel group now added only in spiceinit * updates as per comments * Matrix p_cache (#3461) * Converted quaternion into matrix when pushing onto the p_cache * Removed extra print * Tests docs (#3467) * Reverted Blob change * Added doc strings * Moved usage into source files * Added SpicePosition test * changed thread inc to target * Updated SpicePoition unitTest * Added SpiceRotation unit test * Updated SpiceRotation truth * Merging Dev into ale_integration (#3552) * Fixed optimization flag for Linux and added -g for debug builds * Bundleout Reformat (#3447) * Updated bundle text output to match expected output * Further formatting for the bundle text output * Added history comments * Reformat of RMS output in bundleout.txt * Updated BundleSolutionInfo unittest * Updated version to 3.9.0_RC1 (#3448) * Fixed compiler warnings. Fixes #3418, Fixes #3198 (#3459) * Updated version to 3.9.0_RC1 * Removed compiler warnings with as few changes as possible * Updated pvldiff to support PvlContainers with unequal keyword lengths (#3460) * Updated pvldiff to support PvlContainers with unequal keyword lengths with IngoreKeys * groups now remove keys as well * Added Anaconda cloud badge (#3463) * Ale integration into dev (#3464) * Adds Ale into isis env (#3437) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * remove load call * reordered env.yml * reordered env * unpinned more stuff * updated cmakelists * Naif Keywords/SpicePosition/SpiceRotation now obtained from Ale label and not Spice kernels on Spiceinit (#3442) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * Adding spiceinit classic as back up to Ale implementation. (#3458) * removed redundant scripts * removed unused check from cmake lists * removed debug prints * removed v007 comment and boost debug flag * added ale into ISIS * removed debug prints * working naif keywords from ale * added PvlObject constructor from json * reverted env file * added loadcache(json) * reverted spiceinit main * Spice Rotation and Position now derived from ale * added PvlObject from json null behavior * type * SpiceRotation no longer default to iden matrix * added back ISIS spiceinit classic as a backup to ale * added source keyword to Kernels group * kernel group now added only in spiceinit * updates as per comments * Matrix p_cache (#3461) * Converted quaternion into matrix when pushing onto the p_cache * Removed extra print * Tests docs (#3467) * Reverted Blob change * Added doc strings * Moved usage into source files * Added SpicePosition test * changed thread inc to target * Updated SpicePoition unitTest * Added SpiceRotation unit test * Updated SpiceRotation truth * Update README.md fixes a white space formatting issue in step 7 which prevented a portion of the documentation being rendered correctly * Correct documentation. The file written to the path specified by CNETFILE will be in binary control network format, not plain-text PVL format. The incorrect description in this documentation has been incorrect for at least 7 years, based on the 'Blame' view of the relevant lines in hijitreg/main.cpp, ControlNet/ControlNet.h, and ControlNet/ControlNet.cpp. * Revert "Ale integration into dev (#3464)" This reverts commit 48e4efd1babab7e9608ec15cd4030cc7f51d66c2. * Converted PixelType unit test to gtest (#3478) * converted Pixel type unit test to gtest * removed old unit test and truth data * converted Column unit test to gtest (#3480) * converted Column unit test to gtest * removed redundant tests * Added Working BundleMeasure gtest File (#3470) * Initial Stab at BundleMeasureTest with Fixtures. * Added Working BundleMeasure gtest File * Added a refernce to phocube to camdev docs * Fixes Qmos grid to properly consider PositiveWest and PositiveEast (#3488) * Fixes Qmos grid to properly consider PositiveWest and PositiveEast * clean up * update as per comments * added comments on positive west angles as they come into the GridGraphicsItem constructor * Bundleout Text file update (#3485) * Initial changes to get the bundleout into a better place * Added a few comments and updated how the spacing for the sprintfs is obtained * Reverted unnecessary changes to BundleObservation * Updated file path length checking as suggested * Updates voy2isis to add an optional parameter to specify the instrument name (#3490) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Warning for photomet added (#3486) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * Addressing Stuarts comments * Addressing Kristin's comment * Updating Kaguya Distortion Model with Boresight (Finishing #3492) (#3498) * added warning if anglesource option is used with mixed or topo normalization method; based on github tickets 3451 and 3452 * adding tests * changes to KaguyaTC distortion map * Fixed test on Aarons PR * updated unit test * reseting test data location * Adding camera uptick * Replaced code, removed earlier, that abandons work on a tile Fixes: #3466 (#3497) * Replaced code, removed earlier, that abondons work on a tile when it is outside the output image * Typo * Cisscal Output Change (#3496) * Updated cisscal output cub creation to after bitweight correction and dark subtraction * Updated history in cisscal app xml * Added issue number * Added new test for cisscal * Typo * Removed cube when an exception is thrown rather than moving the instantiation point * Austin Sander's "clemhirescal: Adds support for all MCP gain settings for filters A and D" (#3503) * Added support for all MCP gain settings. Closes #3190 * Revised comments to better reflect updated logic * Added history comment. * Added additional description and link to Robinson paper. * added issue number * Added dynamic creation of version file (#3502) * Added dynamic creation of version file * removed commented line * Update README.md * Updates marci2isis to add variable exposure times and associated frame sequences (#3501) * Update date and other metadata * ckwriter_test_fix * Fix unintentional cmakelists change * Updated voy2isis to add instrument parameter which can be used to specify the instrument name wac or nac if it is not provided in the image label * Added simple test * Updates test and documentation for voy2isis adds instrument_name update * Updated history documentation to add ticket number for voy2isis changes * Updated to reverse frameseq number appropriately with flip * Remove commented-out code * Added documentation for change and test * Updated no exposure duration in varexp file condition * Re-remove iTime.h * Update warning message for assuming a single exposure time * Modified to use the frame and exposure keywords added by marci2isis i… (#3505) * Modified to use the frame and exposure keywords added by marci2isis instead of the varexp.tab file * Added the issue that caused this to need to be fixed * Update main.cpp * Updated Readme with Contributing link * Jenkins Build Script update (#3533) * Updated pipeline to use TestPreferences where necessary * Updated pipeline truth data * Made preference parameter position consistant * Updated pipeline truth data again * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Jenkins * Changed testing avoid which failure * Removed echo * Pointed at install bin instead of build bin * Added a forgotten / * Added the actual install directory * Changed isisroot to point to install directory * More tweeks to the groovy script * Removed conda prefix echo * Moved path update to a single line * new groove * new groove * new groove * new groove * new groove * Updated spice rotation test with isis variable * Testing with appjit * Only testing app jit * Changed app test to -R * More messing with stuffs * Added check for catlab * Changed install directory location * Changed paths again * Echoed pwd in checkout * Retry the print * Pathing one more time * Paths * updated build.groovy * Update Jenkinsfile (#3525) * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * Update Jenkinsfile * …

acpaquette added 6 commits March 28, 2019 14:36

Allowed writting of residuals when value is zero to controlnet pvl

d415371

Merge branch 'dev' of https://github.com/USGS-Astrogeology/ISIS3 into…

d90e56a

… dev

Updated ControlNetVersioner unit test

3a6975f

Fixed pvl labels original pvl labels not being written to the resulti…

da361fc

…ng cube.

Merge branch 'dev' of https://github.com/USGS-Astrogeology/ISIS3 into…

aabdb80

… dev

Updated docstrings and history for updated methods

fd7ab53

acpaquette requested review from scsides, jessemapel, SgStapleton, kberryUSGS and Kelvinrr April 15, 2019 18:24

SgStapleton reviewed Apr 15, 2019

View reviewed changes

isis/src/galileo/apps/gllssi2isis/main.cpp Outdated Show resolved Hide resolved

scsides reviewed Apr 15, 2019

View reviewed changes

jessemapel reviewed Apr 15, 2019

View reviewed changes

isis/src/base/objs/ProcessImport/ProcessImport.cpp Outdated Show resolved Hide resolved

scsides reviewed Apr 15, 2019

View reviewed changes

scsides suggested changes Apr 15, 2019

View reviewed changes

acpaquette added 3 commits April 15, 2019 15:01

Removed the need to set the output cube pixel type

cc1ba4d

Reverted proceeimport changes

a265340

Set the dimensions in the process before processing

415e661

jlaura reviewed Apr 15, 2019

View reviewed changes

Added missing 1 in a history record

3be6073

acpaquette requested a review from scsides April 15, 2019 22:25

SgStapleton reviewed Apr 15, 2019

View reviewed changes

Reverted and applied a more appropriate fix

d648113

scsides previously approved these changes Apr 16, 2019

View reviewed changes

Used outfile obtained at the beginning of the program

7c7a93f

acpaquette dismissed scsides’s stale review via 7c7a93f April 16, 2019 17:54

Added history comment to app xml

a6ea2c5

scsides approved these changes Apr 16, 2019

View reviewed changes

scsides merged commit babbf69 into DOI-USGS:dev Apr 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gllssi2isis Original Label Fix #3226

gllssi2isis Original Label Fix #3226

acpaquette commented Apr 15, 2019

scsides Apr 15, 2019 •

edited

Loading

acpaquette Apr 15, 2019

scsides Apr 15, 2019

acpaquette Apr 15, 2019

acpaquette Apr 15, 2019

scsides left a comment

jlaura Apr 15, 2019

acpaquette Apr 15, 2019

acpaquette Apr 15, 2019

SgStapleton Apr 15, 2019

SgStapleton Apr 15, 2019

SgStapleton Apr 15, 2019

acpaquette commented Apr 16, 2019

scsides Apr 16, 2019

acpaquette Apr 16, 2019

		FileName out = ui.GetFileName("TO");


		FileName outFile = ui.GetFileName("TO");

gllssi2isis Original Label Fix #3226

gllssi2isis Original Label Fix #3226

Conversation

acpaquette commented Apr 15, 2019

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Licensing

scsides Apr 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scsides left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acpaquette commented Apr 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scsides Apr 15, 2019 •

edited

Loading