-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature multiple nodes support #245
Conversation
fix: private key validation / snack-bar close / input max validation
fix: lp token distribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your implementation.
I concern this implementation cannot provide multiple nodes info to to the Angular web app.
Please divide the config into those that depend on the node URL and those that do not, and for those that depend on the node URL, please make the contents of the config itself an array so that the same node can be selected consistently across multiple services.
Then, on the Angular app side, randomly select configuration values in the arrayed configuration and use them.
config as an array. |
@Senna46 |
@YasunoriMATSUOKA |
@YasunoriMATSUOKA
Please review.
If this is also to be ported to web-app, please let me know.
Changes
ueth
&euu