Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature multiple nodes support #245

Closed
wants to merge 10 commits into from

Conversation

Senna46
Copy link
Contributor

@Senna46 Senna46 commented Apr 5, 2022

@YasunoriMATSUOKA
Please review.
If this is also to be ported to web-app, please let me know.

Changes

  • add README.md (Description of config.js)
  • multiple node support (Random select)
  • add Faucet of ueth & euu

Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senna46

Thank you for your implementation.

I concern this implementation cannot provide multiple nodes info to to the Angular web app.

Please divide the config into those that depend on the node URL and those that do not, and for those that depend on the node URL, please make the contents of the config itself an array so that the same node can be selected consistently across multiple services.

Then, on the Angular app side, randomly select configuration values in the arrayed configuration and use them.

@Senna46
Copy link
Contributor Author

Senna46 commented Apr 5, 2022

config as an array.
Do not merge until a frontend has been created for selection

@YasunoriMATSUOKA
Copy link
Contributor

@Senna46
I think you need to add hard coded urls to projects/telescope-extension/editions/ununifi/launch/ununifi-8-private-test/full/config.js. Without the info, nodes can't be selected.

@Senna46
Copy link
Contributor Author

Senna46 commented Apr 5, 2022

@YasunoriMATSUOKA
I did for now for Configs array support.
It will be merged when the frontend is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants