Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Multiple-node-support part of #40 #43

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

Senna46
Copy link
Collaborator

@Senna46 Senna46 commented Apr 6, 2022

@YasunoriMATSUOKA Review plz. And UnUniFi/utils#245

Pull Request on some features of #40.

Changes

Multiple Nodes Support.

Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be duplicate?

Comment on lines 49 to 52
this.configs = configs;
this.config = configs[Math.floor(Math.random() * configs.length)];
this.configs = configs;
this.config = configs[Math.floor(Math.random() * configs.length)];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess 49, 50 and 51, 52 are duplicate. So you should delete one of them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fixed. Thank you.

Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Senna46 Senna46 merged commit 074415f into develop Apr 6, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the feature/multiple-node-random branch April 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants