-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrayed Configs support #40
Conversation
Feature/Multiple-node-support part of #40
@YasunoriMATSUOKA 2c8f1e1 |
I will check it now, wait a moment plz 🙏 |
Great works! This is a matter of preference, but I think configTypeOptions-like name would be good for configOptions or configs. Thank you! |
@YasunoriMATSUOKA 8f1e519 e432d5f Others are support config$ (Observable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a matter of preference, but I think configTypeOptions-like name would be good for configOptions or configs.
I think it would be less confusing to use configType as config too.
Did you check that?
I think it's not a type so it should be changd...
Changes are complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.