feat: remove ActionData to allow arbitrary calls and test cleanups #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Nov 30, 2023
| @@ -63,30 +69,23 @@ contract RelayOrderReactorIntegrationTest is GasSnapshot, Test, Interop, PermitS | |||
| reactor = RelayOrderReactor(RELAY_ORDER_REACTOR); | |||
| permitExecutor = new PermitExecutor(address(filler), reactor, address(filler)); | |||
|
|
|||
| // Swapper max approves permit post | |||
| // Swapper max approves permit post for all input tokens | |||
| vm.startPrank(swapper); | |||
| DAI.approve(address(PERMIT2), type(uint256).max); | |||
| USDC.approve(address(PERMIT2), type(uint256).max); | |||
| PERMIT2.approve(address(DAI), address(reactor), type(uint160).max, type(uint48).max); | |||
| PERMIT2.approve(address(USDC), address(reactor), type(uint160).max, type(uint48).max); | |||
There was a problem hiding this comment.
If the users are approving this router on permit2, can't they then hack each other?
- Alice does
PERMIT2.approve(dai, reactor, maxAmount, maxTimestamp) - Bob calls reactor with an action: target=permit2, call="transfer alice's tokens to bob"
- Permit2 has approval to let the reactor access Alice's tokens, so it accepts the call and gives alice's tokens to bob?
There was a problem hiding this comment.
would be good to add a test to check if this is possible
There was a problem hiding this comment.
Haha totally, I think we don't need to approves on Permit2 because we do signature transfer so I should remove these and see if the tests pass
There was a problem hiding this comment.
Ya we don't need these approves. I think in this design, you definitely cannot be approving this reactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.