Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fixes #99

Merged
merged 9 commits into from
Mar 11, 2024
Merged

Audit fixes #99

merged 9 commits into from
Mar 11, 2024

Conversation

snreynolds
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Forge code coverage:

File % Lines % Statements % Branches % Funcs
script/DeployRelayOrderReactor.s.sol 100.00% (4/4) 100.00% (4/4) 100.00% (0/0) 50.00% (1/2)
src/base/Multicall.sol 100.00% (6/6) 100.00% (8/8) 100.00% (2/2) 100.00% (1/1)
src/lib/FeeEscalatorLib.sol 0.00% (0/15) 0.00% (0/19) 0.00% (0/8) 0.00% (0/4)
src/lib/InputLib.sol 0.00% (0/1) 0.00% (0/2) 100.00% (0/0) 0.00% (0/1)
src/lib/RelayOrderInfoLib.sol 0.00% (0/1) 0.00% (0/2) 100.00% (0/0) 0.00% (0/1)
src/lib/RelayOrderLib.sol 85.71% (12/14) 84.21% (16/19) 75.00% (3/4) 80.00% (4/5)
src/reactors/RelayOrderReactor.sol 100.00% (10/10) 100.00% (13/13) 100.00% (4/4) 100.00% (3/3)
Total 35.45% (39/110) 33.10% (48/145) 50.00% (9/18) 31.25% (15/48)

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed fixes for #2

src/reactors/RelayOrderReactor.sol Outdated Show resolved Hide resolved
src/base/ReactorStructs.sol Outdated Show resolved Hide resolved
src/lib/RelayOrderLib.sol Show resolved Hide resolved
src/lib/RelayOrderLib.sol Show resolved Hide resolved
src/lib/RelayOrderLib.sol Show resolved Hide resolved
test/foundry-tests/lib/RelayOrderLib.t.sol Outdated Show resolved Hide resolved
zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved fix for #4

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved fixes for #6

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, related to #2 but not explictly in the audit issue

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for #7

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for #8

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for #9

zhongeric
zhongeric reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as a follow up to changes made for #2

@snreynolds snreynolds merged commit d32023f into main Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HickupHH3 HickupHH3 HickupHH3 left review comments

@zhongeric zhongeric zhongeric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snreynolds @iamchrissmith @zhongeric @HickupHH3