Make ur_controllers compileable on humble #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
========================================
+ Coverage 3.59% 3.67% +0.08%
========================================
Files 13 392 +379
Lines 947 43134 +42187
Branches 152 6357 +6205
========================================
+ Hits 34 1585 +1551
- Misses 843 41409 +40566
- Partials 70 140 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urfeex
reviewed
Dec 17, 2024
urfeex
approved these changes
Dec 17, 2024
urfeex
force-pushed
the
humble_compatibility
branch
from
50a7b04 to
1aeba6e
Compare
URJala
pushed a commit
to URJala/Universal_Robots_ROS2_Driver
that referenced
this pull request
Dec 20, 2024
No += overload for Duration class on humble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rolling version of ros2_control is kept compatible for compiling on humble distro. Obviously, I need to compile the rolling UR driver on humble too:
There exists no
+=overload forrclcpp::Durationclass on humble, which was introduced later ros2/rclcpp#1988We can use the rclcpp/version.h, or we could also just use the manual assignment.