Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AppRoot): add disableParentTransformForPositionFixedElements prop #5692

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Aug 24, 2023

Перенёс translate3d(0, 0, 0) из CSS в компонент.

UPD


Перенёс `translate3d(0, 0, 0)` из CSS в компонент.
@inomdzhon inomdzhon requested a review from a team as a code owner August 24, 2023 15:03
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 31a9613:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 315.92 KB (+0.04% 🔺)
JS (gzip) 93.05 KB (+0.03% 🔺)
JS (brotli) 76.98 KB (+0.05% 🔺)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 275.76 KB (-0.01% 🔽)
CSS (gzip) 36 KB (-0.03% 🔽)
CSS (brotli) 28.55 KB (-0.06% 🔽)

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (b83e532) 81.91% compared to head (31a9613) 81.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5692      +/-   ##
==========================================
+ Coverage   81.91%   81.92%   +0.01%     
==========================================
  Files         296      296              
  Lines        9768     9775       +7     
  Branches     3096     3098       +2     
==========================================
+ Hits         8001     8008       +7     
  Misses       1767     1767              
Flag Coverage Δ
unittests 81.92% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/AppRoot/AppRoot.tsx 92.66% <100.00%> (+0.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 31a9613

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@inomdzhon inomdzhon merged commit 33e74ff into master Aug 25, 2023
@inomdzhon inomdzhon deleted the i.mirdzhanolov/issue3475/feat/AppRoot-disable-translate-for-mode-embedded branch August 25, 2023 06:33
@inomdzhon inomdzhon mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Добавить в AppRoot при режиме "embedded" отключение transform
3 participants