整理: ユーザー辞書に関するリネーム・lint #1396
Merged
整理: ユーザー辞書に関するリネーム・lint #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hiroshiba |
|
@Hiroshiba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: ユーザー辞書に関するリネーム・lint によるリファクタリング
ユーザー辞書に関するモジュールが整理された（#1329）結果、各変数・クラスの利用範囲がより狭くなった。これを反映して変数名等をリネームし、必要な lint をおこなう必要がある。
このような背景から、ユーザー辞書に関するリネーム・lint によるリファクタリングを提案します。
以下の 4 点の変更をおこないました：
USER_DICT_MIN_PRIORITY→MIN_PRIORITYUSER_DICT_MAX_PRIORITY→MAX_PRIORITYPartOfSpeechDetailをプライベートにリネーム（モジュール内に閉じた利用になったため）accent_associative_rulesの過剰な改行を lintcost_candidatesを切り出し関連 Issue
無し