整理: 辞書クラス・関数をモジュール間で移動 #1329
Merged
整理: 辞書クラス・関数をモジュール間で移動 #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jun 2, 2024
Comment on lines
+17
to
+164
| part_of_speech_detail_2="*", | ||
| part_of_speech_detail_3="*", | ||
| context_id=1345, | ||
| cost_candidates=[ | ||
| -4445, | ||
| 49, | ||
| 1473, | ||
| 2897, | ||
| 4321, | ||
| 5746, | ||
| 6554, | ||
| 7362, | ||
| 8170, | ||
| 8979, | ||
| 15001, | ||
| ], | ||
| accent_associative_rules=[ | ||
| "*", | ||
| "C1", | ||
| "C2", | ||
| "C3", | ||
| "C4", | ||
| "C5", | ||
| ], | ||
| ), | ||
| WordTypes.VERB: PartOfSpeechDetail( | ||
| part_of_speech="動詞", | ||
| part_of_speech_detail_1="自立", | ||
| part_of_speech_detail_2="*", | ||
| part_of_speech_detail_3="*", | ||
| context_id=642, | ||
| cost_candidates=[ | ||
| 3100, | ||
| 6160, | ||
| 6360, | ||
| 6561, | ||
| 6761, | ||
| 6962, | ||
| 7414, | ||
| 7866, | ||
| 8318, | ||
| 8771, | ||
| 13433, | ||
| ], | ||
| accent_associative_rules=[ | ||
| "*", | ||
| ], | ||
| ), | ||
| WordTypes.ADJECTIVE: PartOfSpeechDetail( | ||
| part_of_speech="形容詞", | ||
| part_of_speech_detail_1="自立", | ||
| part_of_speech_detail_2="*", | ||
| part_of_speech_detail_3="*", | ||
| context_id=20, | ||
| cost_candidates=[ | ||
| 1527, | ||
| 3266, | ||
| 3561, | ||
| 3857, | ||
| 4153, | ||
| 4449, | ||
| 5149, | ||
| 5849, | ||
| 6549, | ||
| 7250, | ||
| 10001, | ||
| ], | ||
| accent_associative_rules=[ | ||
| "*", | ||
| ], | ||
| ), | ||
| WordTypes.SUFFIX: PartOfSpeechDetail( | ||
| part_of_speech="名詞", | ||
| part_of_speech_detail_1="接尾", | ||
| part_of_speech_detail_2="一般", | ||
| part_of_speech_detail_3="*", | ||
| context_id=1358, | ||
| cost_candidates=[ | ||
| 4399, | ||
| 5373, | ||
| 6041, | ||
| 6710, | ||
| 7378, | ||
| 8047, | ||
| 9440, | ||
| 10834, | ||
| 12228, | ||
| 13622, | ||
| 15847, | ||
| ], | ||
| accent_associative_rules=[ | ||
| "*", | ||
| "C1", | ||
| "C2", | ||
| "C3", | ||
| "C4", | ||
| "C5", | ||
| ], | ||
| ), | ||
| } |
There was a problem hiding this comment.
これがここに来たのは逆にごっちゃになっちゃになるかもです。
これと、あとpriority周りは分けちゃっても良いかも。や〜一緒でも問題ないかも。。
Hiroshiba
reviewed
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: 辞書クラス・関数をモジュール間で移動してリファクタリング
現在のユーザー辞書は実装が
model/part_of_speech_data/user_dictモジュール間で行き来しており、見通しが悪い。現状調査の結果、以下の 3 つに分類できることがわかった：
実装サイズが大きいため、これに従ってモジュール分割すると見通しが改善する。
このような背景から、辞書クラス・関数をモジュール間で移動するリファクタリングを提案します。
#1242 でのテスト有効化後の方がより安全追記: 済関連 Issue
無し