Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

エンジン情報に関するmodelを追加 #378

Merged
merged 10 commits into from
Mar 23, 2022

Conversation

takana-v
Copy link
Member

内容

題の通りです。
実際に情報を返す部分まで実装するとPRが大きくなるため、modelのみのPRとしています。
もっと良さそうな命名や追加した方が良い情報があればコメント等お願いします。

GET /engine_infoGET /supported_functions_infoで情報を取得できるようにしようと考えています。

関連 Issue

@github-actions
Copy link

github-actions bot commented Mar 21, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 41 4 coverage-90%
voicevox_engine/experimental/init.py 0 0 coverage-100%
voicevox_engine/experimental/guided_extractor.py 124 89 coverage-28%
voicevox_engine/experimental/julius4seg/init.py 0 0 coverage-100%
voicevox_engine/experimental/julius4seg/converter.py 298 295 coverage-1%
voicevox_engine/experimental/julius4seg/sp_inserter.py 116 89 coverage-23%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 163 7 coverage-96%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 167 132 coverage-21%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 43 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 179 66 coverage-63%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 69 9 coverage-87%
voicevox_engine/user_dict.py 98 10 coverage-90%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1743 754 coverage-57%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです!!
細かいのですが、語感をどうすれば良いか難しそうだったのでコメントしてみました!

voicevox_engine/model.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました!

voicevox_engine/model.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
@takana-v
Copy link
Member Author

指摘部分の修正を行いました。
EngineInfoからEngineManifestに変更し、manifest_versionを追加しました。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Manifestすごく良いなと思いました!!
細かい数点だけちょっとsuggestしてみたので、問題なさそうであれば含めて頂けると・・・!

voicevox_engine/model.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
takana-v and others added 3 commits March 23, 2022 10:48
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: aoirint <aoirint@gmail.com>
@Hiroshiba
Copy link
Member

マージしちゃいます!

@Hiroshiba Hiroshiba merged commit 9ee079c into VOICEVOX:master Mar 23, 2022
@takana-v takana-v deleted the add-engine-info-model branch March 23, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants