Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munit 1.0.0-M6 hangs forever with scala-cli test #1577

Closed
bishabosha opened this issue Nov 14, 2022 · 3 comments
Closed

munit 1.0.0-M6 hangs forever with scala-cli test #1577

bishabosha opened this issue Nov 14, 2022 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@bishabosha
Copy link
Contributor

bishabosha commented Nov 14, 2022

Version(s)
0.1.17

Describe the bug
When I run scala-cli test math.test.scala that was written with munit 1.0.0-M6 then the process hangs (forever?)

To Reproduce
put this code in math.test.scala

//> using lib "org.scalameta::munit:1.0.0-M6"

class MathSuite extends munit.FunSuite:
  test("addition") {
    assert(1 + 1 == 2)
  }

  test("multiplication") {
    assert(3 * 7 == 21)
  }
scala-cli test math.test.scala
Compiling project (test, Scala 3.2.0, JVM)
Compiled project (test, Scala 3.2.0, JVM)
MathSuite:
  + addition 0.01s
  + multiplication 0.001s
# shell hangs here

Expected behaviour
exit scala-cli after test completes, I do not have this issue with munit 0.7.29

@bishabosha bishabosha added the bug Something isn't working label Nov 14, 2022
@bishabosha
Copy link
Contributor Author

also reported in scalameta/munit#540

@lwronski lwronski linked a pull request Nov 17, 2022 that will close this issue
@alexarchambault
Copy link
Contributor

To me, this should be a wontfix on the Scala CLI side. munit shouldn't spawn non-daemon threads when it (apparently) doesn't need to.

@Gedochao Gedochao added the wontfix This will not be worked on label Nov 18, 2022
@lwronski
Copy link
Contributor

lwronski commented Nov 18, 2022

@bishabosha Thanks for reporting in Scala CLI. It helps us to fix it in munit by scalameta/munit#606.

It should work from the next release of munit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants