Non-termination regression with scala-cli starting with 1.0.0-M2

[lbialy]

Hi,

I have tried using latest munit versions with scala-cli and found out that termination does not occur if all tests pass since 1.0.0-M2 (M1 works just fine, as all the 0.7.x versions). I have a repro repo here:

https://github.com/lbialy/munit-nonterm-issue

Just run scala-cli test . in this directory and it should hang after printing that all tests passed.

My scala-cli version is 0.1.8.

[tgodzik]

Testing it out this only seems to happen when running from ScalaCLI weirdly enough.

[armanbilge]

Seems the issue was introduced in literally the first PR after 1.0.0-M1 :)

• Respect munitTimeout for non-Future tests #435

//> using lib "org.scalameta::munit::1.0.0-M1+1-11ee9d1c-SNAPSHOT"
//> using repository "https://oss.sonatype.org/content/repositories/snapshots/"
class SanityTest extends munit.FunSuite:
  test("sanity") {
    assert(2 + 2 == 4)
  }

[bishabosha]

I tested this again recently with scala-cli 0.1.17

[alexarchambault]

munit should create daemon threads around here to fix this, I think. See how Scala CLI does for example. Currently, it creates a non-daemon thread, that prevents the JVM from exiting. Hence the hanging out you're seeing here.

[SethTisue]

anybody here have any insight on VirtusLab/scala-cli#2623 ?