Use daemon thread instead of non-daemon thread which prevent JVM from exiting #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
approved these changes
Nov 17, 2022
lwronski
force-pushed
the
use-deamon-thread
branch
from
56153f2 to
d2685fa
Compare
alexarchambault
changed the title
valencik
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Testing locally with a munitJVM/publishLocal and then the following in test.sc:
//> using scala "2.13"
//> using lib "org.scalameta::munit::1.0.0-M6+60-d2685fa2-SNAPSHOT"
class SanityTest extends munit.FunSuite {
test("sanity") {
assert(2 + 2 == 4)
}
}Ran with scala-cli test test.sc we see things properly terminate. Previous versions hang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540.
Based on comment #540 (comment)