Remove copyStyleSheets #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 9, 2023
This CL removes copyStyleSheets in DocumentPictureInPictureOptions. Spec PR: WICG/document-picture-in-picture#79 Bug: 1453540 Change-Id: Ic0ff2739c2de2e534d38ff3d7c04c3963904af4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603788 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1155581}
theodab
pushed a commit
to shaka-project/shaka-player
that referenced
this pull request
Jun 12, 2023
Document Picture-in-Picture API owners are [removing `copyStyleSheets` option](WICG/document-picture-in-picture#79) as it can be done in JavaScript. This PR removes this option and adds code to copy the style sheets of the PiP window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to concerns in #12 and after discussing internally, we've decided that removing this feature is the best path forward