-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't use copyStyleSheets with documentPIP #8314
Conversation
eb767d4
to
69f08d5
Compare
Codecov Report
@@ Coverage Diff @@
## main #8314 +/- ##
==========================================
+ Coverage 82.57% 82.62% +0.04%
==========================================
Files 112 113 +1
Lines 7497 7578 +81
Branches 1809 1820 +11
==========================================
+ Hits 6191 6261 +70
- Misses 1306 1317 +11
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I'm not really sure I agree that it makes any more sense for each player library to manage copying stylesheets, but if that's how it is...
The copy method would ideally not be exposed on the player, as the inline comment. We'll need to address test coverage too.
4910b40
to
873d0c7
Compare
I've moved it and added some basic tests. Let me know if that looks good to you. |
(gentle ping) |
@beaufortfrancois Tahnks for the updates. I've been out for a couple of weeks, back now and will check this week. |
We'll need to do something with this as Chrome Canary already remove |
Thank you @mister-ben for all your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Document Picture-in-Picture API owners are removing
copyStyleSheets
option as it can be done in JavaScript. This PR removes this option and copy all style sheets internally to the PiP window.@mister-ben Please review.