Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when checks are performed #51

Closed
letitz opened this issue May 11, 2021 · 4 comments
Closed

Clarify when checks are performed #51

letitz opened this issue May 11, 2021 · 4 comments

Comments

@letitz
Copy link
Collaborator

letitz commented May 11, 2021

The private network request checks are performed after a connection is obtained. Notably, this is later than when DNS responses are received. Indeed, if a.example resolves to both a public and a private IP address, whether the request will be blocked or not depends on which IP address the browser actually connects to.

We should make this very clear, in both the spec and the explainer, since it is important for site operators to understand.

cc @sleevi

@annevk
Copy link

annevk commented May 12, 2021

So what I've been wondering about (see also #32) is if we can do this as part of "obtain a connection", before returning a connection to the caller. And returning failure if the check fails. It seems that would be the most principled solution.

@sleevi
Copy link
Contributor

sleevi commented May 12, 2021

So WebRTC doesn’t use the same “obtain a connection” step, so if the goal is #32 , that may not work sufficiently for that case, although it may for this specific issue.

That said, I’m not sure I follow the “principled” remark. There’s a host of surprising edge cases either way, so I don’t think it necessarily improves predictability for developers. There is something to be said about the simplicity of the current approach, but just needing to call out the logical consequences explicitly for developers who may not have thought through the implications.

@annevk
Copy link

annevk commented May 12, 2021

It doesn't yet, but it probably should: w3c/webrtc-extensions#73. We keep running into policy mismatches and such.

@letitz
Copy link
Collaborator Author

letitz commented May 31, 2021

Above commit adds this warning to the spec. Remaining: add it to the explainer also.

@letitz letitz closed this as completed in a44c2a1 May 31, 2021
letitz added a commit that referenced this issue May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants