Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider avoiding the use of the word "private" #91

Open
martinthomson opened this issue Nov 22, 2022 · 47 comments · Fixed by #97
Open

Consider avoiding the use of the word "private" #91

martinthomson opened this issue Nov 22, 2022 · 47 comments · Fixed by #97

Comments

@martinthomson
Copy link

I know that local network address space is often referred to as "private" addresses (even in RFC 1918 itself), but this might be misleading. These networks are not private, they just use a locally defined address space. This does not confer any sort of privacy.

Also, this specification provide privacy for network access.

I suggest maybe "local" would be more appropriate, in line with the use in RFC 4291 in "link-local" and "site-local". Though this is probably not entirely correct in that these address spaces are not always local, their address layout is locally defined. "Local" is also an antonym for "global", which is what these addresses are not.

@annevk
Copy link

annevk commented Jan 10, 2023

If we change private to local, which makes some sense to me as at least I tend to refer to it as the local network, we need a new term for what is currently local as well.

loopback seems reasonable for that.

That would give us loopback, local, and public.

@mikewest
Copy link
Member

Ah, names.

"local" is probably fine, and consistent with messaging in places like iOS ("find and connect to devices on your local network"). The "loopback", "local", "public" categorization sounds fine to me.

That said, it would leave us with (at least?) three "local" concepts in Fetch: local scheme, the local cache state, and this new notion of a "local network". Maybe that's fine? The scheme definition seems like it could be confusing.

@annevk
Copy link

annevk commented Jan 11, 2023

I think it works as long as we don't have fetch schemes that do local network thingies. Hopefully those continue to be HTTP(S) schemes.

@letitz
Copy link
Collaborator

letitz commented Jan 11, 2023

Local network is fine with me, whatever makes things easier to understand. It's true that PNA could be parsed as private (network access) instead of (private network) access. The english language is not associative...

As for the new name for "local", "loopback" sounds pretty fine.

Now... We could avoid this altogether if we scrap the distinction between "loopback" and "local", and call it all "local".

While conceptually there is a difference in privilege between the two that made the distinction appealing to me, in practice I am much less worried about users getting pwned by websites served from the local network. What's more, we've run into a rather large snag when trying to apply the secure context restriction to (local -> loopback) fetches. Websites served from the local network often have a very difficult time upgrading to HTTPS. Many are accessed without DNS, at e.g. http://192.168.13.37, which makes an upgrade even more difficult than obtaining and deploying certificates already can be.

As a result, Chrome does not apply the secure context restriction to (local -> loopback) fetches. Maybe this is the time to acknowledge that in the spec?

@annevk
Copy link

annevk commented Jan 11, 2023

I think we need loopback as a standalone concept if only for https://w3c.github.io/webappsec-secure-contexts/ and the specifications building on that, including this one.

I could see sometimes having to group it with local, perhaps, but that's probably best discussed in a separate issue?

@annevk
Copy link

annevk commented Jan 11, 2023

(By the way, I'm not particularly arguing for changing the name of the specification again at this point. If it all ends up being upstreamed eventually that might not be worth the repeated confusion.)

@letitz
Copy link
Collaborator

letitz commented Jan 11, 2023

I think we need loopback as a standalone concept if only for https://w3c.github.io/webappsec-secure-contexts/ and the specifications building on that, including this one.

Fair enough, we can keep the definition.

I could see sometimes having to group it with local, perhaps, but that's probably best discussed in a separate issue?

Right, filed #96.

(By the way, I'm not particularly arguing for changing the name of the specification again at this point. If it all ends up being upstreamed eventually that might not be worth the repeated confusion.)

Happy to reword things in the spec text itself, to avoid using the word "private".

I would prefer not the rename the whole spec if we can avoid it, as we have a fair number of references to it scattered across the web now, and we already renamed it once. Even though that was much earlier in the project's lifetime, it was already confusing enough.

That said, if @martinthomson feels like the spec name itself is a blocking issue, then we can do it.

@martinthomson
Copy link
Author

Do you mean the repository name or the title? Either way...

¯\(°_o)/¯

@letitz
Copy link
Collaborator

letitz commented Jan 13, 2023

Both, as it seems confusing to change one but not the other.

In any case, having discussed this with others, I recognize that a specification entitled Private Network Access that never mentions "private network" would be confusing too.

Let's go for Local Network Access, and talk about local networks in the spec text.

@letitz
Copy link
Collaborator

letitz commented Jan 13, 2023

cc @yoavweiss who renamed the repo last time.

@yoavweiss
Copy link
Collaborator

Renamed! Please verify everything is in working order..

@letitz
Copy link
Collaborator

letitz commented Jan 17, 2023

Thanks! Everything looks fine to me! Now to rename the words inside the repo...

@letitz
Copy link
Collaborator

letitz commented Jan 18, 2023

@johnathan79717 is interested in writing his first spec PR, will tackle renaming things.

@letitz
Copy link
Collaborator

letitz commented Jan 25, 2023

In the course of writing his PR, @johnathan79717 realized that renaming everything would include renaming the CORS headers: Access-Control-Allow-Private-Network and Access-Control-Request-Private-Network.

Before we realized this, we believed that even though renaming was a tedious affair with a fairly large amount of work involved, the victims were circumscribed to our team in Chrome. We were willing to bear the cost for a better outcome and cross-browser agreement.

Unfortunately, renaming the headers would require a web deprecation. We have already started sending the new headers to servers in warning-only mode for a few milestones in Chrome, and have been badgering developers to support them. Telling them "Actually, you know that work you just did to support our change? Could you do it again?" in the name of spec purity goes squarely against the priority of constituencies.

This is too bad, as I think we all agree Local Network Access would be a better name, and it would be best not to muddy the waters around the word "private". That said, we believe that we should reverse the decision to rename and instead keep the old name. In the future, we would welcome this kind of constructive feedback earlier in the process, when changes are not so hard to make.

@annevk
Copy link

annevk commented Jan 25, 2023

  1. We can still have good terminology internally even if the web-exposed terminology is bad. E.g., XMLHttpRequest.
  2. Chromium deciding to ship a WICG specification shouldn't really make it impossible to change things when they are actually getting standardized. That would be rather bad. We're not here to ratify whatever you happened to ship, but rather jointly work on what we think is best for the web platform over the long term.

@letitz
Copy link
Collaborator

letitz commented Jan 25, 2023

  1. We can still have good terminology internally even if the web-exposed terminology is bad. E.g., XMLHttpRequest.

This is true. We could rename everything but the headers. That would make it confusing to developers, however, so I'd rather avoid that.

  1. Chromium deciding to ship a WICG specification shouldn't really make it impossible to change things when they are actually getting standardized. That would be rather bad. We're not here to ratify whatever you happened to ship, but rather jointly work on what we think is best for the web platform over the long term.

While that's a fair point in general, it has been over a year and a half since this spec's name was set to Private Network Access. There was ample time to jointly work on choosing the perfect name, including by speaking up during the public Blink intent process where the headers were shipped.

@annevk
Copy link

annevk commented Jan 26, 2023

I'm sorry, but neither blink-dev nor WICG is a suitable substitute for the standardization process.

I'm personally — not wishing to speak for others here — quite flexible on the header names as I understand the dilemma, but I will forcefully object to this line of reasoning.

@mikewest
Copy link
Member

Hey @annevk!

I don't think either experimentation in Blink or WICG drafts substitute for the standardization process. They're instead an integral part of it, ideally leading to more collaboration and shared understanding of a problem space. This particular case is one in which I've been pretty happy with the way we've been working together over the last few years here on this WICG draft, with the TAG (w3ctag/design-reviews#572), various conversations in WebAppSec, standards positions requests (mozilla/standards-positions#143 and webkit-dev), and outreach to developers in various forums. I think we're doing standardization, together, and I hope that continues!

Part of that work, of course, is experimentation and testing in the real world. Chrome has taken an incremental approach, with a couple of stabs at shipping preflights starting in Nov 2021 and eventually sticking the landing in Chrome 104 (August 2022). That took a good deal of conversation with folks about the headers they should expect and the headers they should return. We're still not enforcing them, but entities like SAP and Salesforce have done some work to support this rollout and I think it would be unfortunate to start over again and wait for them to both accept a new spelling and deploy it to various customer sites. I think this creates some reliance interests in the current header naming, which doesn't seem unreasonable to me to respect.

Names are hard. We changed the spec to "Private Network Access" after some discussion with clever folks in Feb 2021, and though we might not have landed on the perfect name, I don't think it's a bad name, nor do I think it's substantially misleading (especially given the RFC's description of the IP ranges we rely upon as "private").

If you feel strongly about referring to these networks as "local" in the specification, I can live with that. At the same time, I agree with Titouan that it would be somewhat confusing for developers to have a concept with one name in one place and another in another. The delta between "local" and "private" doesn't seem broad enough to me to justify that discrepancy, but if it seems broad enough to you, then I'm sure we can work something out.

Thanks!

@othermaciej
Copy link

To people who aren't familiar with the IETF terminology for IP address ranges, or do not find it the most salient, it's likely they'd think "Private Network" referred to a VPN or similar technology, rather than to what's colloquially known as the private network. Or in general may suggest some form of privacy protection is involved.

I also agree with Anne that it's inappropriate to suggests standards conversations should be held in a Blink development forum (like the Blink intent process on blink-dev) rather than in a standards or incubation forum (like this repo).

As far as the transition cost of renaming the headers for Chrome, which has shipped these since August 2022: do we have any usage data that would tell us how widespread the reliance is on the current header names? If it's very high, then it may indeed be too late to change. If it's zero or close, then renaming shouldn't be a big deal; the mere fact of having shipped without significant usage doesn't create much of a reliance interest. If it's in between, then supporting both header names for a transition period may be viable. Having this data, if it exists, would help evaluate whether changing the header names is a reasonable option.

Finally, I want to mention that all of the major browser engines have previously renamed or removed features that they were the first to ship, as the standards process progressed. While having shipped is certainly a relevant factor, it hasn't been and can't be a trump card, especially at the incubation stage.

@mikewest
Copy link
Member

Hey @othermaciej, thanks for weighing in. I'd like to separate this conversation into two parts: standardization on the one hand, and "local" vs "private" on the other.

Regarding the former, I think we can agree that Blink's launch process is tangential to standardization. I hope we can also agree that this particular specification is an example of productive outreach, good discussion, and general agreement on direction. If there's disagreement on that, I'd honestly love to chat, because it would mean that my internal understanding of collaboration is substantially off. To be clear, I agree with you that blink-dev@ is not a great place for standards discussions, and I think that Titouan et al. have reached out well beyond blink-dev@ for feedback on every aspect of this proposal, pretty consistently over a period of years. This includes being quite responsive to a renaming request almost two years ago that resulted in the current nomenclature.

Regarding the latter: first, I continue to view the distinction between "private network" and "local network" as fairly trivial, but I grant that "local" is marginally less likely to cause confusion in the main. My renaming concerns are practical, not aesthetic. Second, the renaming costs for Chrome are trivial, summed up as s/-Private-Network/-Local-Network/ and then sending a few emails to folks we've been talking to about this for quite some time. The costs to the ecosystem are somewhat less trivial, not because the change is difficult, but because it's change, and change is unfortunately impractical. We're asking developers to take time away from features they'd like to build to revisit their support for our collective desire to raise a new security boundary. It's not unreasonable to see that as friction, as much as we'd like to assume universal acclaim for the protection we'd like to provide.

That said, I think it's reasonable for you to ask for metrics. I'm not sure if we have what you're asking for, but (modulo enterprise environments' reluctance to share telemetry data with Google, which has caused some hiccups in the past) @letitz probably knows whether we track what percentage of preflight requests are currently satisfied by a response, which seems like a proxy for the reliance interests discussed above.

Finally, I really hope that a discussion over names doesn't result in disagreement over principles. The core of the specification we're discussing is, I think, a reasonable direction for us to be moving in together. I hope we remain in agreement on that!

@cwilso
Copy link
Member

cwilso commented Jan 27, 2023

As one of Chrome's Web standards tech leads, let me underscore Mike's comment: Blink's launch process, and blink-dev as a communication venue, is not considered part of the standardization process. Blink's launch process DOES require simultaneously working in the open standards process, and specifically open standards incubation venues such as WICG; and this spec was been openly incubated in WICG for quite some time before Chrome shipped it. The only reason Blink's launch process (and blink-dev) bear mentioning here is that it provides ongoing indication of how baked we think an incubation is, to the point we are willing to ship it. We are working toward improving these indicators as well, and making sure they're clearly represented in the standards incubation venues too.

As stated above, I don't think it's impossible to change names once they are shipped; there are plenty of examples where that has happened across browsers. If this is "we would support this moving into a WG now, and moving toward REC and implementing in other engines, but this name is unacceptable", then I expect we would work to figure out how to make this happen. If this is an academic point, I'm not sure that there is value in renaming at this point.

@jub0bs
Copy link
Contributor

jub0bs commented Jan 29, 2023

@letitz

It's true that PNA could be parsed as private (network access) instead of (private network) access. The english language is not associative...

Hyphenation (or lack thereof) lifts the ambiguity: "local-network access".

@jub0bs
Copy link
Contributor

jub0bs commented Jan 29, 2023

As the author and maintainer of a (very new, still in beta) CORS middleware library, I'm a bit worried by this rename. I want and do support Private Network Access, but if my users know it as Local Network Access, I may have to

  • either change the name of the relevant option (which, for established libraries, would trigger the need for a new major version),
  • or at least provide some alias for it under the new name (and, as a result, the conceptual surface area of my library's API wouldn't be as small as it can ideally be).

I also suspect that the discrepancy between the name of the spec ("local") and the names of the relevant request and response headers ("private") is likely to cause more confusion than elucidation. CORS itself is already the cause of much misunderstanding by developers; it would be a pity to add to that confusion.

I myself am utterly confused by the rename of this repo despite no rename of the spec itself...

@letitz
Copy link
Collaborator

letitz commented Jan 31, 2023

Thanks for chiming in with a web developer's point of view, @jub0bs! I think this illustrates @mikewest's point about reliance interests well.

I myself am utterly confused by the rename of this repo despite no rename of the spec itself...

Yes, sorry about that! We stopped midway through the rename, and the current situation is not tenable. We're working on fixing the discrepancy ASAP.

@jub0bs
Copy link
Contributor

jub0bs commented Feb 1, 2023

We're working on fixing the discrepancy ASAP.

Any timeline for this? I plan to release the first minor version of my library over the next few days, and it would be nice for its API to use the term ("private" or "local") you settle on.

@letitz
Copy link
Collaborator

letitz commented Feb 1, 2023

I was hoping to hear from @annevk and @othermaciej before proceeding. Folks, do you believe we should still go ahead with the renaming?

@annevk
Copy link

annevk commented Feb 7, 2023

Colleagues and I would prefer "Local Network Access". I was personally hoping @martinthomson would weigh in (again).

@letitz
Copy link
Collaborator

letitz commented Apr 20, 2023

Preliminary data from said UseCounter in Chrome beta seems to confirm that a non-trivial number of pages rely on the header naming. I'm still waiting to see data from stable to confirm.

In the meantime, I am curious to hear other browser vendors' opinions on this bit specifically:

We also think it would be a bad idea to have the specification name its terms differently from the header names, since the original concern is developer confusion, but that issue isn't as critical as keeping the existing developer-visible header names. If it helps the specification go through the standards process to use names that differ from the header names, that would be acceptable.

I'm rather keen to end this whole saga and either finish renaming everything in Chromium, or undo our changes.

@letitz
Copy link
Collaborator

letitz commented Apr 28, 2023

Re-opening to track un-renaming the headers, at least.

@letitz letitz reopened this Apr 28, 2023
@letitz
Copy link
Collaborator

letitz commented May 9, 2023

Headers are back to -Private-Network. I think it makes most sense to go all the way and rename the spec back to PNA. What do others think?

@jub0bs
Copy link
Contributor

jub0bs commented May 9, 2023

@letitz Will there still be a transition period during which -Local-Network headers are supported? If so, is such a transition period really warranted?

@letitz
Copy link
Collaborator

letitz commented May 12, 2023

Good question! There will be no transition period, because no browser ever shipped support for the -Local-Network headers.

@jub0bs
Copy link
Contributor

jub0bs commented May 12, 2023

@letitz Thanks for clarifying. That's good news for maintainers of CORS middleware libraries.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jul 10, 2023
This reverts commit 09f21d8c48ebc54193b12874c895648c69dfbe92.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in WPTs
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in wpt file names.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Weizhong Xia <weizhong@google.com>
> Cr-Commit-Position: refs/heads/main@{#1115802}

Bug: 1418287
Change-Id: I8f29e58c4a0e8741be98bc9fd640510e1473e61c
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 10, 2023
…ion_metrics.md"

This reverts commit 7893736.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in web_mitigation_metrics.md
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in
> web_mitigation_metrics.md.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: If5d23739cba049908731f5fa97aff9f79a4037cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334390
> Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1118030}

Bug: 1418287
Change-Id: Icc21a4fc48a12e85038c017a1f0821a6660f0f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670561
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168121}
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 10, 2023
…oup_browsertest.cc"

This reverts commit c6a9a9a.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in interest_group_browsertest.cc
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in
> interest_group_browsertest.cc.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
>
> Change-Id: If1f8bbc9c5e8d87c8761dcf33ba41abd60114da0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336326
> Reviewed-by: Caleb Raitto <caraitto@chromium.org>
> Auto-Submit: Jonathan Hao <phao@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1117589}

Bug: 1418287
Change-Id: I476f0f99ee9d6192ad6ffa7080a70c240a1e9ad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4669624
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168148}
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 10, 2023
…owsertest.cc"

This reverts commit cdd0a01.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in web_view_browsertest.cc
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in
> web_view_browsertest.cc.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
>
> Change-Id: I52fa91a66f225f7076cc1f1d4a9068c0ea880d82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335665
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Auto-Submit: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Bo Liu <boliu@chromium.org>
> Commit-Queue: Bo Liu <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1117536}

Bug: 1418287
Change-Id: I4658cb3f7ee33e7ab89c0a290dc551db79022828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4671591
Reviewed-by: Bo Liu <boliu@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168202}
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 10, 2023
… local"

This reverts commit 262019a.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename content setting from private to local
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback) and rename the spec to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the occurrences in content settings.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: I5f1e6bfc5fcda6598e761eb201274ea9409609f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335304
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1117088}

Bug: 1418287
Change-Id: I3a3afd97546650506410d57b81831ee63404dc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670562
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168233}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jul 11, 2023
This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jul 11, 2023
This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168815}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jul 11, 2023
This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168815}
jgraham pushed a commit to web-platform-tests/rfcs that referenced this issue Jul 18, 2023
In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

Chromium has also renamed private to local in
https://source.chromium.org/chromium/chromium/src/+/d5b320062c4982d2e215386e068826f8bc97c512 so the ip-address-overrides switch value needs to be updated too.

This PR makes the corresponding changes in the RFC.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 20, 2023
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Auto-Submit: Jonathan Hao <phao@chromium.org>
Quick-Run: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jul 21, 2023
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamychromium.org>
> Commit-Queue: Jonathan Hao <phaochromium.org>
> Cr-Commit-Position: refs/heads/main{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemerychromium.org>
Commit-Queue: Arthur Hemery <ahemerychromium.org>
Auto-Submit: Jonathan Hao <phaochromium.org>
Quick-Run: Jonathan Hao <phaochromium.org>
Cr-Commit-Position: refs/heads/main{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968

UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jul 21, 2023
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamychromium.org>
> Commit-Queue: Jonathan Hao <phaochromium.org>
> Cr-Commit-Position: refs/heads/main{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemerychromium.org>
Commit-Queue: Arthur Hemery <ahemerychromium.org>
Auto-Submit: Jonathan Hao <phaochromium.org>
Quick-Run: Jonathan Hao <phaochromium.org>
Cr-Commit-Position: refs/heads/main{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968

UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jul 21, 2023
…ivate to local in request.cc", a=testonly

Automatic update from web-platform-tests
Revert "[Local Network Access] Rename private to local in request.cc"

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in request.cc
>
> In WICG/private-network-access#91, we decided to
> rename (public, private, local) IP address spaces to (public, local,
> loopback). The spec has already been renamed in
> WICG/private-network-access#97.
> New spec:
> https://wicg.github.io/local-network-access/#ip-address-space-heading
>
> This CL renames the string representation in request.cc. It also updates
> a mixed content wpt because it uses targetAddressSpace defined in
> Request.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043
> Reviewed-by: Camille Lamy <clamychromium.org>
> Commit-Queue: Jonathan Hao <phaochromium.org>
> Cr-Commit-Position: refs/heads/main{#1115707}

Bug: 1418287
Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564
Reviewed-by: Arthur Hemery <ahemerychromium.org>
Commit-Queue: Arthur Hemery <ahemerychromium.org>
Auto-Submit: Jonathan Hao <phaochromium.org>
Quick-Run: Jonathan Hao <phaochromium.org>
Cr-Commit-Position: refs/heads/main{#1168815}

--

wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b
wpt-pr: 40968

UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88
@danielcompton
Copy link

danielcompton commented Oct 15, 2023

I'm coming to this issue as part of working on nginxinc/nginx-s3-gateway#180 and wasn't quite sure where this issue landed. Is the following summary correct?

  • Webkit supports this standard, but may use Access-Control-Allow-Local-Network instead of Access-Control-Allow-Private-Network when they come to implement it: Local Network Access WebKit/standards-positions#163
  • Mozilla supports this standard but hasn't started working on it. It is unclear which header name they will use: 1481298
  • Chrome has shipped with Access-Control-Allow-Private-Network but is open to also including Access-Control-Allow-Local-Network if another browser ships with it.
  • Anyone who is implementing support for this header today only needs to handle Access-Control-Allow-Private-Network, but should consider that they may also need to support a second header Access-Control-Allow-Local-Network in the future.

@annevk
Copy link

annevk commented Oct 16, 2023

I think that's correct, modulo calling it a standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.