Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Local Network Access] Rename private to local in WPTs" #40948

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This reverts commit 09f21d8c48ebc54193b12874c895648c69dfbe92.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:

[Local Network Access] Rename private to local in WPTs

In WICG/private-network-access#91, we decided to
rename Private Network Access to Local Network Access. The spec has
already been renamed in
WICG/private-network-access#97. The latest spec:
https://wicg.github.io/local-network-access/

This CL renames PrivateNetwork to LocalNetwork in wpt file names.

There are so many places to rename, so during the process, there will
inevitably be inconsistencies. Hopefully, we shall resolve all of them
soon.

Bug: 1418287
Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1115802}

Bug: 1418287
Change-Id: I8f29e58c4a0e8741be98bc9fd640510e1473e61c

Reviewed-on: https://chromium-review.googlesource.com/4675623
WPT-Export-Revision: 278499a9b9afe00fb73fd7d5445b4106526ffe4d

This reverts commit 09f21d8c48ebc54193b12874c895648c69dfbe92.

Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106

Original change's description:
> [Local Network Access] Rename private to local in WPTs
>
> In WICG/private-network-access#91, we decided to
> rename Private Network Access to Local Network Access. The spec has
> already been renamed in
> WICG/private-network-access#97. The latest spec:
> https://wicg.github.io/local-network-access/
>
> This CL renames PrivateNetwork to LocalNetwork in wpt file names.
>
> There are so many places to rename, so during the process, there will
> inevitably be inconsistencies. Hopefully, we shall resolve all of them
> soon.
>
> Bug: 1418287
> Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033
> Commit-Queue: Jonathan Hao <phao@chromium.org>
> Reviewed-by: Weizhong Xia <weizhong@google.com>
> Cr-Commit-Position: refs/heads/main@{#1115802}

Bug: 1418287
Change-Id: I8f29e58c4a0e8741be98bc9fd640510e1473e61c
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot
Copy link
Collaborator Author

Close this PR because the Chromium CL has been abandoned.

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-4675623 branch July 26, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants