Update for AbortSignal's abort reason #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2021
|
The build should be fixed now (tested with part of your change), but unfortunately when I rerun the build on your PR it uses the old workflow. Could you maybe rebase and push again so it triggers a new run? |
domenic
force-pushed
the
abortsignal-changes
branch
from
697dbce
to
767cf77
Compare
|
Build fixed! |
|
Thanks, merging! Tracking bug for implementation change: https://bugs.chromium.org/p/chromium/issues/detail?id=1272822. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 27, 2022
This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 29, 2022
This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611791 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#997819}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 29, 2022
This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611791 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#997819}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 29, 2022
This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611791 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#997819}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 16, 2022
…tTask, a=testonly Automatic update from web-platform-tests Scheduling APIs: Use abort reason in postTask This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611791 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#997819} -- wpt-commits: 4ae557ce407849af3e4cb7ac68af6f364b5ac3f5 wpt-pr: 33824
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 25, 2022
…tTask, a=testonly Automatic update from web-platform-tests Scheduling APIs: Use abort reason in postTask This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611791 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#997819} -- wpt-commits: 4ae557ce407849af3e4cb7ac68af6f364b5ac3f5 wpt-pr: 33824
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This updates postTask to use the abort reason when rejecting the associated promise due to a signal aborting. If no abort reason is specified during abort(), the reason defaults to an AbortError, which is the current behavior. Given this and the newness of the API, the impact of this change should be minimal. Spec PR: WICG/scheduling-apis#53 Bug: 1272822 Change-Id: Ia1dbf93e2d7e1b2e507609d0cb6f93f67deddc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611791 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#997819} NOKEYCHECK=True GitOrigin-RevId: 7ed45930d7eff3dd90e0c0f4e6ed511a81da6f17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of whatwg/dom#1030. Basically, now
AbortSignals can be aborted with custom abort reasons, e.g."TimeoutError"DOMExceptions being a prominent case, so downstream specs need to support this.This is a normative change so please remember to implement it :).