Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbortSignal's abort reason downstream integration #1030

Closed
13 tasks done
annevk opened this issue Nov 10, 2021 · 11 comments
Closed
13 tasks done

AbortSignal's abort reason downstream integration #1030

annevk opened this issue Nov 10, 2021 · 11 comments
Labels
meta Changes to the ecosystem around the standard, not its contents topic: aborting AbortController and AbortSignal

Comments

@annevk
Copy link
Member

annevk commented Nov 10, 2021 •
edited by domenic
Loading

I somehow forgot that AbortSignal is a pretty popular API these days. There's more than Fetch and Streams to update. For each impacted specification not only do we need to migrate away from the "aborted flag", we also need to make sure they take into account the object's abort reason, in a matter that is appropriate for the API.
@annevk annevk added meta Changes to the ecosystem around the standard, not its contents topic: aborting AbortController and AbortSignal labels Nov 10, 2021
@annevk annevk mentioned this issue Nov 10, 2021
Merged
3 tasks
@yutakahirano
Copy link
Member

@domenic created a list of affected specs at whatwg/streams#1165 (comment).

@annevk
Copy link
Member Author

annevk commented Nov 10, 2021

Thanks, added. If someone could file issues for those as a first step that would be appreciated.

@jyasskin
Copy link
Member

jyasskin commented Nov 10, 2021 •
edited
Loading

I noticed it in Credential Management (w3c/webappsec-credential-management#176), which you have. Thanks!

@saschanaz saschanaz mentioned this issue Nov 10, 2021
Merged
@equalsJeffH equalsJeffH mentioned this issue Nov 10, 2021
Closed
@equalsJeffH

This comment has been minimized.

Sign in to view
@equalsJeffH equalsJeffH mentioned this issue Nov 11, 2021
Merged
@domenic domenic mentioned this issue Nov 11, 2021
Open
@domenic

This comment has been minimized.

Sign in to view
@miketaylr
Copy link
Member

(FYI: Web Bluetooth was fixed in WebBluetoothCG/web-bluetooth@c7c0901)

domenic added a commit to WICG/navigation-api that referenced this issue Nov 17, 2021
@domenic
Update for changes to the AbortSignal spec
c38d5a4 
Part of whatwg/dom#1030.
@domenic domenic mentioned this issue Nov 17, 2021
Merged
domenic added a commit to WICG/navigation-api that referenced this issue Nov 17, 2021
@domenic
Update for changes to the AbortSignal spec
e8060a6 
Part of whatwg/dom#1030.
domenic pushed a commit to whatwg/streams that referenced this issue Nov 19, 2021
@nidhijaju
Integrate abort reasons
95973b4 
Following on from whatwg/dom#1027, with introduces custom abort reasons, this uses the AbortSignal's abort reason in the ReadableStreamPipeTo function. It also updates WritableStreamAbort to use the reason to signal abort.

Closes #1165. Part of whatwg/dom#1030.
domenic added a commit to domenic/scheduling-apis that referenced this issue Nov 19, 2021
@domenic
Update for AbortSignal's abort reason
697dbce 
Part of whatwg/dom#1030.
@domenic domenic mentioned this issue Nov 19, 2021
Merged
@nsatragno nsatragno mentioned this issue Nov 22, 2021
Closed
@nsatragno
Copy link

I just filed a bug against WebOTP, can you update the tracking comment above? Thanks ❤️

domenic added a commit to domenic/scheduling-apis that referenced this issue Nov 22, 2021
@domenic
Update for AbortSignal's abort reason
767cf77 
Part of whatwg/dom#1030.
shaseley pushed a commit to WICG/scheduling-apis that referenced this issue Nov 22, 2021
@domenic
Update for AbortSignal's abort reason (#53)
2a4905b 
Part of whatwg/dom#1030.
@annevk annevk mentioned this issue Nov 23, 2021
Closed
@miketaylr
Copy link
Member

I filed a bug for WebNFC at w3c/web-nfc#630.

@nidhijaju
Copy link
Contributor

FYI: Geolocation Sensor was fixed in w3c/geolocation-sensor#53 and Idle Detection was fixed in WICG/idle-detection#48

There is also an ongoing PR for EyeDropper: WICG/eyedropper-api#25

@LiviaMedeiros LiviaMedeiros mentioned this issue Jul 17, 2022
Closed
@nidhijaju
Copy link
Contributor

We finally landed the Fetch PR (whatwg/fetch#1343) as well, so I think we can close this issue now :)

@domenic
Copy link
Member

domenic commented Oct 6, 2022

Huge success; great work everyone!!

@domenic domenic closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Changes to the ecosystem around the standard, not its contents topic: aborting AbortController and AbortSignal
Milestone
No milestone
Development

No branches or pull requests
8 participants
@miketaylr @jyasskin @equalsJeffH @domenic @annevk @nsatragno @yutakahirano @nidhijaju