-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish a todo of setting browserSignal's data-version field. #657
Conversation
Also provides "list" as a parameter to get structured head list as it needs. Also changed header's "true" to "?1" since the latter is the correct true value for headers.
@miketaylr Mind taking a look at the small change? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SHA: 77df320 Reason: push, by miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Was the data version at one time (or will be) an attribute within the response? Now it is a header value, so in what case might it differ across keys? Is there a possibility an IG's keys could be split across different signalsURL fetches? BTW,
is referenced elsewhere as |
Good question. Sent a PR to remove the TODO. About [=fetching trusted signals=], it's a feature of bikeshed. "Bikeshed can automatically handle a wide range of English conjugations and pluralizations" |
谢谢 and 🤯 |
Also provides "list" as a parameter to get structured head list as it
needs.
Also changed header's "true" to "?1" since the latter is the correct
true value for headers.
Preview | Diff