Remove an obsolete todo about data-version. #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explainer mentioned requesting trusted bidding signals using multiple requests (for a `generateBid()`), and then need to make sure that the Data-Version header's value is consistent in these responses. That's only kept there as an open option (possible optimization), but not what's implemented. So removing the todo which is obsolete.
|
@JensenPaul A one line change that removes an obsolete TODO. PTAL, thanks! |
github-actions bot
added a commit
that referenced
this pull request
Jun 26, 2023
SHA: cdc7f80 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Jun 27, 2023
SHA: cdc7f80 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explainer mentioned requesting trusted bidding signals using multiple requests (for a
generateBid()), and then need to make sure that the Data-Version header's value is consistent in these responses. That's only kept there as an open option (possible optimization), but not what's implemented. So removing the todo which is obsolete.Preview | Diff