Probable fix for https://github.com/INN/Largo/issues/1381 #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not able to duplicate the bug described in #1381, but this looks like a fix: exclude the current post from the posts that get returned in any query in the Largo_Related class, which is what feeds the Largo Related Posts widget. Please watch tests on this one.
|
Tests are a 👍 |
benlk
commented
Dec 13, 2016
| @@ -33,6 +33,7 @@ function widget( $args, $instance ) { | |||
| $rel_posts = new WP_Query( array( | |||
| 'post__in' => $related->ids(), | |||
| 'nopaging' => 1, | |||
| 'post__not_in' => array( $post->ID ), | |||
There was a problem hiding this comment.
If this makes it work in your testing, then I'm fine with it, but I'm puzzled.
https://codex.wordpress.org/Class_Reference/WP_Query#Post_.26_Page_Parameters
'post__not_in' should be ignored when 'post__in' is set in WP_Query.
There was a problem hiding this comment.
the specific issue I ran into was then post__in was blank
There was a problem hiding this comment.
Ah, then this makes sense. 👍
Related: #884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not able to duplicate the bug described in #1381, but this looks like a fix: exclude the current post from the posts that get returned in any query in the Largo_Related class, which is what feeds the Largo Related Posts widget.
Please wait for tests on this one.