Exclude the current post from yet another area where we're creating lists of IDs #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ists of related post IDs
rclations
reviewed
Feb 22, 2017
inc/related-content.php
Outdated
| ! in_array( $q->post->ID, $this->post_ids ) // only add it if it wasn't already there | ||
| && $q->post->ID != $this->post_id // do not add the id of the current post, because we do not want to ever return that | ||
| ) { | ||
| $this->post_ids[] = (int) trim($q->post->ID); |
inc/related-content.php
Outdated
| $this->post_ids[] = (int) trim( $q->post->ID ); | ||
| if ( | ||
| ! in_array( $q->post->ID, $this->post_ids ) // only add it if it wasn't already there | ||
| && $q->post->ID != $this->post_id // do not add the id of the current post, because we do not want to ever return that |
There was a problem hiding this comment.
I think we should allow type juggling here, because of the possibility that we may be comparing a string post ID to a numeric post ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
add_from_query, the method of the class that is responsible for generating lists of IDs in multiple parts of theLargo_Relatedclass.Why
Something in one of the two calls to
WP_QueryinLargo_Related->get_series_posts()is ignoring thepost__not_inargument on the query, so now I'm going to just exclude the current post's post ID from ever being added to the list of IDsThis is because of HelpScout ticket 559, and is a continuation of issue #1381 and the work done in PR #1385.