[analysis] Add a FullLattice concept and Inverted lattice #6038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 21, 2023
kripken
approved these changes
Oct 23, 2023
ashleynh
approved these changes
Oct 24, 2023
| template<typename L> | ||
| concept FullLattice = | ||
| Lattice<L> && requires(const L& lattice, | ||
| const typename L::Element& constElem, |
There was a problem hiding this comment.
Can you explain why access to L::Element& is needed as both a const and !const?
There was a problem hiding this comment.
This is for the join and meet operations, which need to take a mutable reference as their first argument because it will be modified in-place. Otherwise all other uses of elements are const.
| const typename L::Element& constElem, | ||
| typename L::Element& elem) { | ||
| { lattice.getTop() } noexcept -> std::same_as<typename L::Element>; | ||
| { lattice.meet(elem, constElem) } noexcept -> std::same_as<bool>; |
There was a problem hiding this comment.
Is meet intended to be the greatest lower bound?
There was a problem hiding this comment.
Yes, will add a comment.
The FullLattice concept extends the base Lattice with `getTop` and `meet` operations. The `Inverted` lattice uses these operations to reverse the order of an arbitrary full lattice, for example to create a lattice of integers ordered by `>` rather than by `<`.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…y#6038) The FullLattice concept extends the base Lattice with `getTop` and `meet` operations. The `Inverted` lattice uses these operations to reverse the order of an arbitrary full lattice, for example to create a lattice of integers ordered by `>` rather than by `<`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FullLattice concept extends the base Lattice with
getTopandmeetoperations. The
Invertedlattice uses these operations to reverse the order ofan arbitrary full lattice, for example to create a lattice of integers ordered
by
>rather than by<.