[analysis] Implement Flat lattice #6039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 21, 2023
kripken
approved these changes
Oct 23, 2023
| #else | ||
| template<typename T> | ||
| #endif | ||
| struct Flat { |
There was a problem hiding this comment.
PR description could be a comment in the header.
tlively
force-pushed
the
flat-lattice
branch
2 times, most recently
from
c545121 to
d1fe61a
Compare
ashleynh
approved these changes
Oct 25, 2023
| LatticeComparison compare(const Element& a, const Element& b) const noexcept { | ||
| if (a.index() < b.index()) { | ||
| return LESS; | ||
| } else if (a.index() > b.index()) { |
There was a problem hiding this comment.
What interface is index() from?
There was a problem hiding this comment.
It's built into std::variant: https://en.cppreference.com/w/cpp/utility/variant/index
Given a type `T`, `Flat<T>` is the lattice where none of the values of `T` are comparable except with themselves, but they are all greater than a common bottom element not in `T` and less than a common top element also not in `T`.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Given a type `T`, `Flat<T>` is the lattice where none of the values of `T` are comparable except with themselves, but they are all greater than a common bottom element not in `T` and less than a common top element also not in `T`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a type
T,Flat<T>is the lattice where none of the values ofTarecomparable except with themselves, but they are all greater than a common bottom
element not in
Tand less than a common top element also not inT.