Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser] Parse rethrow #6155

Merged
merged 2 commits into from
Dec 13, 2023
Merged

[Parser] Parse rethrow #6155

merged 2 commits into from
Dec 13, 2023

Conversation

tlively
Copy link
Member

@tlively tlively commented Dec 7, 2023

Like delegate, rethrow takes a Try label. Refactor the delegate handling so
that Try can share its logic.

@tlively tlively mentioned this pull request Dec 7, 2023
Merged
@tlively
Copy link
Member Author

tlively commented Dec 7, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Dec 8, 2023
Merged
Merged
@tlively tlively requested a review from aheejin December 12, 2023 22:01
aheejin
aheejin approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this can be simpler after you did all the hard work in #6128! Can we add a test where rethrow is in the try part of the innermost try (and catch part of an outer try) as well?

Base automatically changed from parser-table-ops to main December 12, 2023 23:40
@tlively
[Parser] Parse rethrow
7b628b6 
Like `delegate`, rethrow takes a `Try` label. Refactor the delegate handling so
that `Try` can share its logic.
@tlively
add suggested test
c248799
@tlively tlively merged commit 8e91992 into main Dec 13, 2023
27 checks passed
@tlively tlively deleted the parser-rethrow branch December 13, 2023 02:50
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@tlively @radekdoulik
[Parser] Parse rethrow (WebAssembly#6155)
de700bf 
Like `delegate`, rethrow takes a `Try` label. Refactor the delegate handling so
that `Try` can share its logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheejin aheejin aheejin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlively @aheejin