[Parser] Parse string types and operations #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
kripken
reviewed
Dec 11, 2023
| @@ -59,7 +59,7 @@ struct ParseInput { | |||
| std::optional<uint8_t> takeU8(); | |||
| std::optional<double> takeF64(); | |||
| std::optional<float> takeF32(); | |||
| std::optional<std::string_view> takeString(); | |||
| std::optional<std::string> takeString(); | |||
There was a problem hiding this comment.
The string view this method returned was dangling whenever the string contained an escape sequence, so I had to change it to return an owned string to avoid ownership problems.
| ;; CHECK-NEXT: ) | ||
| (func $string-new (param i32 i32) (result stringref) | ||
| local.get 0 | ||
| local.get 1 |
There was a problem hiding this comment.
Why do I see local.get 1 in the input but not in the output?
There was a problem hiding this comment.
This was a bug! Fixed now.
kripken
approved these changes
Dec 11, 2023
tlively
added a commit
that referenced
this pull request
Dec 13, 2023
tlively
added a commit
that referenced
this pull request
Dec 13, 2023
Parse `array.new_elem`, `array.init_data`, and `array.init_elem`. Accidentally also includes: * [Parser] Parse string types and operations (#6161)
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Parse `array.new_elem`, `array.init_data`, and `array.init_elem`. Accidentally also includes: * [Parser] Parse string types and operations (WebAssembly#6161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.