Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed saving strategy "better", update docs, and release v0.7 #470

Merged
merged 6 commits into from
Jul 21, 2024
Merged

Fix failed saving strategy "better", update docs, and release v0.7 #470

merged 6 commits into from
Jul 21, 2024

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Jul 21, 2024 •
edited
Loading

What does this PR do?

  1. fix Model saving bug #464;
  2. update docs and fix Docs building failed because of Unicode #471;
  3. release v0.7;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10026017637

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.035%
Totals Coverage Status
Change from base Build 10019927876: 0.0%
Covered Lines: 10580
Relevant Lines: 12590
💛 - Coveralls

@WenjieDu WenjieDu merged commit b103df4 into main Jul 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs building failed because of Unicode Model saving bug
2 participants
@WenjieDu @coveralls