Sidebar permalink panel a11y improvements (#12030)

* Use ExternalLink for links with target=_blank. * Adjust font-weight values accordingly to current CSS coding standards.
WordPress · Nov 19, 2018 · 3a57743 · 3a57743
1 parent 6ae6285
commit 3a57743
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/packages/edit-post/src/components/sidebar/post-link/index.js b/packages/edit-post/src/components/sidebar/post-link/index.js
@@ -8,7 +8,7 @@ import { get } from 'lodash';
  */
 import { Fragment } from '@wordpress/element';
 import { __ } from '@wordpress/i18n';
-import { PanelBody, TextControl } from '@wordpress/components';
+import { PanelBody, TextControl, ExternalLink } from '@wordpress/components';
 import { withSelect, withDispatch } from '@wordpress/data';
 import { compose, ifCondition, withState } from '@wordpress/compose';
 import { addQueryArgs } from '@wordpress/url';
@@ -77,7 +77,7 @@ function PostLink( {
 			<p className="edit-post-post-link__preview-label">
 				{ __( 'Preview' ) }
 			</p>
-			<a
+			<ExternalLink
 				className="edit-post-post-link__link"
 				href={ postLink }
 				target="_blank"
@@ -88,14 +88,14 @@ function PostLink( {
 					</Fragment> ) :
 					postLink
 				}
-			</a>
-			<a
+			</ExternalLink>
+			<ExternalLink
 				className="edit-post-post-link__permalink-settings"
 				href={ addQueryArgs( 'options-permalink.php' ) }
 				target="_blank"
 			>
 				{ __( 'Permalink Settings' ) }
-			</a>
+			</ExternalLink>
 		</PanelBody>
 	);
 }

diff --git a/packages/edit-post/src/components/sidebar/post-link/style.scss b/packages/edit-post/src/components/sidebar/post-link/style.scss
@@ -1,9 +1,5 @@
-.edit-post-post-link__link {
-	font-weight: 600;
-}
-
 .edit-post-post-link__link-post-name {
-	font-weight: 800;
+	font-weight: 600;
 }
 
 .edit-post-post-link__preview-label {
@@ -16,6 +12,5 @@
 
 .edit-post-post-link__permalink-settings {
 	margin-top: 1em;
-	font-weight: 500;
 	display: block;
 }