Sidebar permalink panel a11y improvements #12030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this out from #11874
In the new permalink sidebar panel, the "Preview" and "Permalink Settings" links use
target="_blank"but users are not informed the link is going to open in a new browser's tab. Gutenberg has a component for this:ExternalLink, which adds the standard visually hidden text(opens in a new tab)and also adds an icon.This PR uses
ExternalLinkfor these two links.Also, the value core currently used for the
boldfont weight is600. See #11687, #5848, and, more importantly, https://core.trac.wordpress.org/changeset/37740. Core doesn't use800or500. The second commit in this PR changes the links font weight to a normal weight and keeps thepost-namepart of the link bold.Screenshot after: