Use @wordpress/escape-html escapeHTML in Link UI in preference to Lod…

…ash method (#46184) * Use WP escape package in block library * Utilise WP method over lodash method
WordPress · Nov 30, 2022 · 8ee32ce · 8ee32ce
1 parent d5c68c8
commit 8ee32ce
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/block-library/package.json b/packages/block-library/package.json
@@ -45,6 +45,7 @@
 		"@wordpress/deprecated": "file:../deprecated",
 		"@wordpress/dom": "file:../dom",
 		"@wordpress/element": "file:../element",
+		"@wordpress/escape-html": "file:../escape-html",
 		"@wordpress/hooks": "file:../hooks",
 		"@wordpress/html-entities": "file:../html-entities",
 		"@wordpress/i18n": "file:../i18n",

diff --git a/packages/block-library/src/navigation-link/update-attributes.js b/packages/block-library/src/navigation-link/update-attributes.js
@@ -1,12 +1,8 @@
-/**
- * External dependencies
- */
-import escapeHtml from 'escape-html';
-
 /**
  * WordPress dependencies
  */
 import { safeDecodeURI } from '@wordpress/url';
+import { escapeHTML } from '@wordpress/escape-html';
 
 /**
  * @typedef {'post-type'|'custom'|'taxonomy'|'post-type-archive'} WPNavigationLinkKind
@@ -78,8 +74,8 @@ export const updateAttributes = (
 	// - https://github.com/WordPress/gutenberg/pull/41063
 	// - https://github.com/WordPress/gutenberg/pull/18617.
 	const label = useNewLabel
-		? escapeHtml( newLabel )
-		: originalLabel || escapeHtml( newUrlWithoutHttp );
+		? escapeHTML( newLabel )
+		: originalLabel || escapeHTML( newUrlWithoutHttp );
 
 	// In https://github.com/WordPress/gutenberg/pull/24670 we decided to use "tag" in favor of "post_tag"
 	const type = newType === 'post_tag' ? 'tag' : newType.replace( '-', '_' );