Use @wordpress/escape-html escapeHTML in Link UI in preference to Lodash method #46184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
scruffian,
MaggieCabrera,
ajlende and
draganescu
getdave
added
[Type] Code Quality
|
Size Change: +20 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…ash method (WordPress#46184) * Use WP escape package in block library * Utilise WP method over lodash method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #46013 we moved to using
@wordpress/escape-html'sescapeHTMLmethod in preference tolodashto avoid coupling lodash to the editor.This PR mirrors that change in the original code location within the Nav Link Block.
Why?
Code consistency in case we need to refactor to a single instance of the Link UI code in future.
How?
Adds package to block lib. Uses functino. Removes lodash.
Testing Instructions
&or any other chars requiring escaping.&.Testing Instructions for Keyboard
Screenshots or screencast