Skip to content

Commit

Permalink
Revert "[RN Mobile] RichText: Return early when content has changed i…
Browse files Browse the repository at this point in the history
…n onSelectionChangeFromAztec (#41682)" (#42089)

This reverts commit 86ded7c.
  • Loading branch information
Siobhan Bamber authored Jul 4, 2022
1 parent 7af66e9 commit eb85da3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion packages/react-native-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ For each user feature we should also add a importance categorization label to i

- [*] Add 'Insert from URL' option to Video block [#41493]
- [*] Image block copies the alt text from the media library when selecting an item [#41839]
- [**] RichText - Improve performance by dropping events during quick typing [#41682]
- [*] Introduce "block recovery" option for invalid blocks [#41988]

## 1.78.1
Expand Down
9 changes: 0 additions & 9 deletions packages/rich-text/src/component/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -657,15 +657,6 @@ export class RichText extends Component {
return;
}

// Check for and discard events during quick typing. Updating the selection during quick typing isn't
// necessary and can cause UI lags. (see https://github.com/WordPress/gutenberg/pull/41682.)
if (
contentWithoutRootTag !== this.value &&
this.lastAztecEventType === 'selection change'
) {
return;
}

this.comesFromAztec = true;
this.firedAfterTextChanged = true; // Selection change event always fires after the fact.

Expand Down

0 comments on commit eb85da3

Please sign in to comment.