[RNMobile] Revert: RichText: Return early when content has changed in onSelectionChangeFromAztec #42089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
the
Mobile App - i.e. Android or iOS
SiobhyB
changed the title
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
SiobhyB
added
the
Mobile App - Automation
dcalhoun
approved these changes
Jul 1, 2022
|
@dcalhoun @SiobhyB - based on the discussion in PR #42046, it sounds like the bug only occurs on iOS. I haven't been able to reproduce it on Android yet. If it's true that only iOS is affected, do you think we should consider keeping the change for Android? The performance issues on lower-end Android devices can be significant, and it would be nice to improve the performance on those devices soon (assuming no new bugs are introduced, of course). I am concerned about other hidden bugs, and I think it's reasonable to revert if you're not comfortable keeping the change on Android without further investigation. |
|
@kbrown9, thank you for bringing this up for discussion! I agree that it'd be great if at least Android users were able to benefit from the significant performance improvements your PR brought. I'm also a little hesitant for the reasons you describe. It feels like the code around the RichText component is already tricky to debug and it might be preferable to spend a bit more time understanding the code before deciding on a workaround. My gut is telling me that it may be best to revert for now, to help us get on top of the e2e errors, and then possibly have a new PR for either debugging the core issue or introducing an Android-only workaround. I could be swayed, though. @dcalhoun, @fluiddot, pinging to get your opinions here, too. Do you have a preference for how to proceed? |
Agreed, the
Sounds good to me continuing with this PR, at least for addressing the E2E tests failures, and then focus on the Android-only workaround 👍 . |
SiobhyB
deleted the
revert-41682-update/rich_text_native_on_selection_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41682
gutenberg-mobile: [RNMobile] Revert: RichText: Return early when content has changed in onSelectionChangeFromAztec wordpress-mobile/gutenberg-mobile#4999What?
It was recently found that the changes in #41682 lead to a bug where a block's last character can either be stripped or pushed to a new paragraph.
Why?
@dcalhoun's exploration of this issue at #42046 (comment) revealed that this will be a complicated issue to fix, so we'll be reverting the original changes for now.
How?
The changes from the original PR have been reverted. Given this is a revert for an enhancement, no regressions are foreseen.