Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button arrangement in "poster" video attribute #20704

Closed
mtias opened this issue Mar 8, 2020 · 3 comments · Fixed by #20754
Closed

Button arrangement in "poster" video attribute #20704

mtias opened this issue Mar 8, 2020 · 3 comments · Fixed by #20754
Assignees
@jasmussen
Labels
Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress

Comments

@mtias
Copy link
Member

mtias commented Mar 8, 2020

This doesn't look great. We should consider it as we look at the sidebar controls:

image

cc @jasmussen @pablohoneyhoney
@mtias mtias added the Needs Design Needs design efforts. label Mar 8, 2020
@jasmussen
Copy link
Contributor

Yeah what a mix of things going on here.

What are the heuristics for the labels here? Some of them are pieced together from post types, right? And what can we do as far as changing the verbiage? Not just unifying the case structure, but rephrasing as well. For example it seems worth trying:

Image

[Replace]   Remove

With "Replace" being either primary or secondary and "Remove" being tertiary.

@mtias
Copy link
Member Author

mtias commented Mar 9, 2020

Some of them are pieced together from post types, right?

I don't think so, this is just custom to the Video block.

jasmussen added a commit that referenced this issue Mar 10, 2020
@jasmussen
Polish poster image button arrangement.
9140ce4 
Fixes #20704.

This changes the phrasing, the button types, and the arrangement of the video poster buttons.
@jasmussen jasmussen mentioned this issue Mar 10, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 10, 2020
@jasmussen
Copy link
Contributor

Created #20754 to address this.

jasmussen added a commit that referenced this issue Mar 10, 2020
@jasmussen
Polish poster image button arrangement.
3483464 
Fixes #20704.

This changes the phrasing, the button types, and the arrangement of the video poster buttons.
jasmussen added a commit that referenced this issue Mar 10, 2020
@jasmussen
Polish poster image button arrangement. (#20754)
8f337a8 
Fixes #20704.

This changes the phrasing, the button types, and the arrangement of the video poster buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polish poster image button arrangement. WordPress/gutenberg
2 participants
@mtias @jasmussen