-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button arrangement in "poster" video attribute #20704
Comments
Yeah what a mix of things going on here. What are the heuristics for the labels here? Some of them are pieced together from post types, right? And what can we do as far as changing the verbiage? Not just unifying the case structure, but rephrasing as well. For example it seems worth trying:
With "Replace" being either primary or secondary and "Remove" being tertiary. |
I don't think so, this is just custom to the Video block. |
Fixes #20704. This changes the phrasing, the button types, and the arrangement of the video poster buttons.
Created #20754 to address this. |
Fixes #20704. This changes the phrasing, the button types, and the arrangement of the video poster buttons.
Fixes #20704. This changes the phrasing, the button types, and the arrangement of the video poster buttons.
This doesn't look great. We should consider it as we look at the sidebar controls:
cc @jasmussen @pablohoneyhoney
The text was updated successfully, but these errors were encountered: