Polish poster image button arrangement. #20754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
jasmussen
commented
Mar 10, 2020
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| .components-base-control__label { | |||
| display: inline-block; | |||
| margin-bottom: $grid-unit-05; | |||
| margin-bottom: $grid-unit-10; | |||
There was a problem hiding this comment.
This is intentionally a "global" change. As we refine the sidebar overall, 4px is such a small margin it might not even have been there.
mtias
approved these changes
Mar 10, 2020
|
Size Change: -38 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
Fixes #20704. This changes the phrasing, the button types, and the arrangement of the video poster buttons.
jasmussen
force-pushed
the
try/polish-poster-image-buttons
branch
from
9140ce4
to
3483464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20704.
This changes the phrasing, the button types, and the arrangement of the video poster buttons.
Before:
After:
This also changes the "Remove" button from being a destructive link button, to simply being a tertiary button. It's not a destructive action as it doesn't delete anything, and you can just undo if you did something by accident.