Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should select by dragging into nested block #44673

Closed
github-actions bot opened this issue Oct 4, 2022 · 1 comment · Fixed by #48035
Closed

[Flaky Test] should select by dragging into nested block #44673

github-actions bot opened this issue Oct 4, 2022 · 1 comment · Fixed by #48035
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should select by dragging into nested block

Test path

/test/e2e/specs/editor/various/multi-block-selection.spec.js

Errors

[2022-10-04T17:05:53.227Z] Test passed after 1 failed attempt on rnmobile/upgrade-android-api-31.
[2022-12-15T06:04:27.985Z] Test passed after 1 failed attempt on add/flaky-tests-comment.
[2022-12-16T11:01:42.641Z] Test passed after 1 failed attempt on add/ability-to-not-update-selection-with-replace-blocks.
[2022-12-19T13:18:21.611Z] Test passed after 1 failed attempt on trunk.
[2022-12-19T15:28:01.174Z] Test passed after 1 failed attempt on revert/46070.
[2022-12-19T23:43:49.506Z] Test passed after 1 failed attempt on fix/tag-processor-back-too-far.
[2022-12-20T11:03:33.245Z] Test passed after 1 failed attempt on fix/source-link-params.
[2022-12-21T16:31:29.458Z] Test passed after 1 failed attempt on trunk.
[2022-12-22T09:49:52.281Z] Test passed after 1 failed attempt on try/integrate-openverse.
[2022-12-22T12:14:31.335Z] Test passed after 1 failed attempt on try/integrate-openverse.
[2022-12-23T16:01:28.685Z] Test passed after 1 failed attempt on trunk.
[2022-12-25T22:46:01.416Z] Test passed after 1 failed attempt on trunk.
[2022-12-30T04:53:03.459Z] Test passed after 1 failed attempt on shadow-presets.
[2023-01-03T13:22:49.998Z] Test passed after 1 failed attempt on remove/block-inspector-button.
[2023-01-04T17:10:20.163Z] Test passed after 1 failed attempt on trunk.
[2023-01-04T20:50:35.310Z] Test passed after 1 failed attempt on revert-46314-try/white-default-site-visual-editor.
[2023-01-05T07:20:03.317Z] Test passed after 1 failed attempt on try/list-view-scroll-off-screen-selected-blocks-into-view.
[2023-01-05T16:44:29.951Z] Test passed after 1 failed attempt on trunk.
[2023-01-09T01:30:37.540Z] Test passed after 1 failed attempt on update/push-changes-to-global-styles-label-text.
[2023-01-10T06:21:46.557Z] Test passed after 1 failed attempt on update/button-ts.
[2023-01-10T15:49:37.770Z] Test passed after 1 failed attempt on fix/47022.
[2023-01-10T17:27:22.042Z] Test passed after 1 failed attempt on ribaricplusplus.
[2023-01-10T20:10:29.713Z] Test passed after 1 failed attempt on try/zoom-out-iframe-scale.
[2023-01-10T23:04:38.617Z] Test passed after 1 failed attempt on add/html-character-reference-decoder.
[2023-01-12T07:55:19.544Z] Test passed after 1 failed attempt on update/stabilize-inspector-control-groups.
[2023-01-12T11:49:28.665Z] Test passed after 1 failed attempt on fix/useblockpreview-iframe-styles.
[2023-01-12T13:19:20.794Z] Test passed after 1 failed attempt on try/custom-label-to-nav-block-list-view-appender.
[2023-01-12T22:47:02.747Z] Test passed after 1 failed attempt on try/test-46510-2.
[2023-01-13T10:08:12.925Z] Test passed after 1 failed attempt on fix/parity-with-cores-php-ci-jobs.
[2023-01-13T11:27:42.486Z] Test passed after 1 failed attempt on fix/parity-with-cores-php-ci-jobs.
[2023-01-13T11:57:11.525Z] Test passed after 1 failed attempt on try/featured-image-caption.
[2023-01-16T15:43:36.707Z] Test passed after 1 failed attempt on remove/skip-block-serialization-util.
[2023-01-17T06:48:57.115Z] Test passed after 1 failed attempt on try/conditional-sticky-notice-or-hiding.
[2023-01-18T00:28:20.143Z] Test passed after 1 failed attempt on add/template-part-creation-unit-tests.
[2023-01-19T04:14:48.646Z] Test passed after 1 failed attempt on update/stabilise-BlockPreview-props.
[2023-01-19T09:44:26.328Z] Test passed after 1 failed attempt on shadow-template-support.
[2023-01-20T12:12:29.187Z] Test passed after 1 failed attempt on remove/lodash-clone.
[2023-01-20T12:38:28.102Z] Test passed after 1 failed attempt on update/sync-editor-settings.
[2023-01-23T15:33:53.269Z] Test passed after 1 failed attempt on trunk.
[2023-01-26T10:55:31.065Z] Test passed after 1 failed attempt on trunk.
[2023-01-26T14:24:00.799Z] Test passed after 1 failed attempt on add/experimental-editor-settings.
[2023-01-26T20:56:51.024Z] Test passed after 1 failed attempt on update/combobox-control-ts.
[2023-01-26T21:49:38.606Z] Test passed after 1 failed attempt on update/custom-css-load-order.
[2023-01-27T11:11:13.293Z] Test passed after 1 failed attempt on fix/constrained-tabbing-safari-firefox-failures.
[2023-01-30T03:41:49.854Z] Test passed after 1 failed attempt on try/stabilise-height-control-component-in-block-editor.
[2023-01-30T09:47:55.244Z] Test passed after 1 failed attempt on try/remove-excerpt-paragraph-margin.
[2023-01-30T10:12:07.465Z] Test passed after 1 failed attempt on fix/constrained-tabbing-safari-firefox-failures.
[2023-01-31T10:09:24.746Z] Test passed after 1 failed attempt on rnmobile/release_1.87.3.
[2023-01-31T15:48:16.776Z] Test passed after 1 failed attempt on try/suspense-site-edit-2.
[2023-02-03T10:12:42.509Z] Test passed after 1 failed attempt on refactor/unnecessary-act-popover-tests.
[2023-02-03T13:40:51.438Z] Test passed after 1 failed attempt on fix/complementary-area-initial-state.
[2023-02-06T00:14:25.303Z] Test passed after 1 failed attempt on try/fix-toolspanel-on-paste-styles.
[2023-02-06T07:53:00.808Z] Test passed after 1 failed attempt on add/settings-drawer-to-link-control.
[2023-02-06T13:28:07.176Z] Test passed after 1 failed attempt on trunk.
[2023-02-06T16:16:31.869Z] Test passed after 1 failed attempt on refactor/lodash-merge-data.
[2023-02-07T09:25:49.824Z] Test passed after 1 failed attempt on try/list-view-scroll-off-screen-selected-blocks-into-view.
[2023-02-07T13:29:59.192Z] Test passed after 1 failed attempt on fix/undo-create-navigation.
[2023-02-07T16:57:41.798Z] Test passed after 1 failed attempt on refactor/use-patterns-categories-sorting.
[2023-02-07T20:44:36.559Z] Test passed after 1 failed attempt on add/button-border-support.
[2023-02-07T21:12:21.925Z] Test passed after 1 failed attempt on remove/lodash-wordpress-data.
[2023-02-08T10:35:30.194Z] Test passed after 1 failed attempt on add/template-revision-button.
[2023-02-08T12:40:28.025Z] Test passed after 1 failed attempt on link-ui-with-2-navigations.
[2023-02-08T20:09:03.428Z] Test passed after 1 failed attempt on fix/multiple-select.
[2023-02-10T11:27:56.516Z] Test passed after 1 failed attempt on try/dynamic-text-autocompleter.
[2023-02-13T10:41:39.819Z] Test passed after 1 failed attempt on add/nested-template-level.
[2023-02-13T11:51:50.432Z] Test passed after 1 failed attempt on link-ui-with-2-navigations.
[2023-02-13T16:26:07.838Z] Test passed after 1 failed attempt on trunk.
[2023-02-13T17:28:13.873Z] Test passed after 1 failed attempt on refactor/context-system-provider-merge.
[2023-02-13T17:57:09.617Z] Test passed after 1 failed attempt on refactor/context-system-provider-merge.
[2023-02-14T03:06:54.278Z] Test passed after 1 failed attempt on fix/root-padding-in-editor.
[2023-02-14T19:36:08.643Z] Test passed after 1 failed attempt on fix/Multiple-overwrites-on-rest-controller-class.
[2023-02-15T08:31:02.544Z] Test passed after 1 failed attempt on try/revert-iframe-for-core.
[2023-02-15T11:21:42.997Z] Test passed after 1 failed attempt on form-fields.
[2023-02-16T15:20:27.121Z] Test passed after 1 failed attempt on fix/i18n-strings.
[2023-02-17T07:31:13.136Z] Test passed after 1 failed attempt on fix/i18n-strings.
[2023-02-17T11:07:48.612Z] Test passed after 2 failed attempts on fix/site-editor-performance-tests.
[2023-02-17T15:20:52.355Z] Test passed after 2 failed attempts on update/disable-layout-toolbar-controls-for-content-locked-blocks.
[2023-02-17T15:21:09.142Z] Test passed after 1 failed attempt on fix/make-navigation-page-list-load-its-items-on-sidebar.
[2023-02-17T15:58:39.052Z] Test passed after 1 failed attempt on fix/firefox-input-rules.
[2023-02-17T21:46:23.392Z] Test passed after 1 failed attempt on try/image-upload-prepublish.
[2023-02-17T22:00:20.221Z] Test passed after 1 failed attempt on tweak/default-logo-size.
[2023-02-17T22:49:53.439Z] Test passed after 1 failed attempt on update/overlay-colors-code.
[2023-02-20T18:43:52.312Z] Test passed after 1 failed attempt on add/html-tag-processor-wp-6-3-compat-layer.
[2023-02-21T06:00:57.310Z] Test passed after 1 failed attempt on add/layout-aware-margin-styles-for-block-level-global-styles.
[2023-02-21T08:06:18.674Z] Test passed after 1 failed attempt on remove/lodash-merge.
[2023-02-21T08:51:08.717Z] Test passed after 1 failed attempt on trunk.
[2023-02-21T11:23:24.558Z] Test passed after 1 failed attempt on add/unit-test-against-current-wp-minus-one.
[2023-02-21T11:27:53.659Z] Test passed after 1 failed attempt on update/gen-block-lib-list.
[2023-02-22T16:17:33.042Z] Test passed after 1 failed attempt on add/site-tagline-example.
[2023-02-22T16:20:36.891Z] Test passed after 1 failed attempt on trunk.
[2023-02-23T11:37:41.967Z] Test passed after 1 failed attempt on try/link-preview.
[2023-02-27T06:53:29.878Z] Test passed after 1 failed attempt on trunk.
[2023-02-27T14:35:29.295Z] Test passed after 1 failed attempt on remove/old-e2e-tests.
[2023-02-27T15:00:46.373Z] Test passed after 1 failed attempt on remove/lodash-get-remaining-blocks.
[2023-02-27T19:57:36.744Z] Test passed after 1 failed attempt on try/set-attrs-idle.
[2023-02-27T23:54:07.080Z] Test passed after 1 failed attempt on fix/autocomplete-guard-set-state.
[2023-02-28T05:38:09.082Z] Test passed after 1 failed attempt on try/detect-box-shadow-value-in-style-book.
[2023-02-28T11:05:38.065Z] Test passed after 1 failed attempt on add/component-tests-to-duotone-hooks.
[2023-03-01T00:22:34.872Z] Test passed after 1 failed attempt on fix/global-styles-fluid-typography-setting.
[2023-03-01T07:00:02.493Z] Test passed after 1 failed attempt on update/legacy-tooltip.
[2023-03-01T10:03:18.222Z] Test passed after 1 failed attempt on trunk.
[2023-03-01T10:14:39.765Z] Test passed after 1 failed attempt on trunk.
[2023-03-01T10:30:47.246Z] Test passed after 1 failed attempt on trunk.
[2023-03-01T14:28:17.687Z] Test passed after 1 failed attempt on update/navigation-fallback-simplify.
[2023-03-01T18:37:36.853Z] Test passed after 1 failed attempt on wp/6.2.
[2023-03-02T09:15:31.713Z] Test passed after 1 failed attempt on fix/widget-importer-widget-group.
[2023-03-02T09:20:35.659Z] Test passed after 1 failed attempt on trunk.
[2023-03-02T11:41:13.077Z] Test passed after 1 failed attempt on fix/plugin-check-nav-inspector-controls.
[2023-03-02T11:56:07.560Z] Test passed after 1 failed attempt on address-review-to-48204.
[2023-03-02T13:46:05.419Z] Test passed after 2 failed attempts on update/navigation-sidebar-default.
[2023-11-14T21:28:18.096Z] Test passed after 1 failed attempt on experiment/show-styles-inherited-values.
[2023-11-23T11:36:31.019Z] Test passed after 2 failed attempts on try/block-edit-lazy-loading.
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 0

  Array [
    1,
-   2,
  ]

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/multi-block-selection.spec.js:458:5
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 0

  Array [
    1,
-   2,
  ]

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/multi-block-selection.spec.js:458:5
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Oct 4, 2022
@github-actions
Copy link
Author

github-actions bot commented Nov 4, 2022

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 4, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2022
@github-actions github-actions bot reopened this Dec 15, 2022
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 16, 2022
github-actions bot referenced this issue Dec 21, 2022
…mported and reused. (#46485)

Co-authored-by: Daniel Bachhuber <daniel.bachhuber@automattic.com>
github-actions bot referenced this issue Dec 25, 2022
…ate to (#44883)

* Store current region in state so region navigation remains in-order.

* Remove constant tabindex from regions. Add back when needed. Try to find better focus locations.

* Use closest to determine the current region since it operates in a DOM upwards motion. From the current element, I should get the closest wrapping region.

* Better code comment.

* Revert focus/tabindex changes.

* Try fixing E2E tests.

* Add changelog entry.

* Fix edge case with selector matching regions without our negative tabindex.

* Try again to only select regions with tabindex of -1. Fix E2E.

* Fix E2E.

* Fix E2E.

* Fix E2E.
github-actions bot referenced this issue Jan 4, 2023
github-actions bot referenced this issue Jan 5, 2023
* Add new shouldDirectInsert prop to enabling disabling of direct insertion

* Disable direct insertion in Offcanvas
github-actions bot referenced this issue Feb 22, 2023
* feat(link-control): show text only labels

* chore(link-control): change setting button title

* fix(link-control): update tests

* chore(link-control): use editor top level interface css class to add the label text

* fix(link-control): reduce show-icon-labels css specificity

* fix: pass slot in off-canvas-editor and navigation-link
github-actions bot referenced this issue Mar 1, 2023
…r blocks (#48585)

* Navigation: Don't create a fallback navigation menu if there are inner blocks

* move const declarations higher
github-actions bot referenced this issue Mar 2, 2023
* Release script: Update react-native-editor version to 1.89.0

* Release script: Update with changes from 'npm run core preios'

* Mobile - Update changelog

* Release script: Update react-native-editor version to 1.89.1

* Release script: Update with changes from 'npm run core preios'

* fix: Enable access to block settings within UBE (#48435)

* fix: Enable access to block settings within UBE

The "Show more settings" menu item is no longer included in the block
toolbar after #46709 merged. Rather than relying upon that menu item,
this conditionally displays the sidebar toggle button whenever a block
is selected.

* fix: Disable white space stripping that breaks nested CSS selectors

CSS selectors rely upon a single white space between selectors to
represent an ancestor relationship. Globally removing white space in the
stylesheet breaks this functionality, as it transforms the selector to
target a single element with all the selectors.

The white space stripping should likely be replaced with a proper CSS
minification long term.

* fix: Hide block actions unrelated to editing a single block

Hide the entire "block settings" drop-down menu now that we no longer
rely upon it to access the "Show more settings" menu option that was
removed entirely.

* refactor: Relocate script toggling block settings visibility

This relates more to editor behavior than the post content.

* fix: Apply styles and script to editor canvas iframe

The editor canvas now relies upon an iframe. It is not possible to style
elements within an iframe from the parent context. This copies the
styles from the parent conext to the iframe.

Additionally, the logic selecting the first block also failed due to the
block not existing when it was invoked. This relocates that logic until
after the iframe is ready.

* fix: Expand conditional checks for partial DOM trees

On Android, there were times where the iframe was present, but the
nested window was not yet ready.

* refactor: Rename for brevity

* fix: Avoid React removing appended iframe styles

Append the styles to the `document` element, as React will remove the
mutation to the `head` element.

* docs: Add change log entry

---------

Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
@github-actions github-actions bot reopened this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant